Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support spring boot3 #82

Merged
merged 2 commits into from
Sep 30, 2024
Merged

support spring boot3 #82

merged 2 commits into from
Sep 30, 2024

Conversation

qiujiayu
Copy link
Contributor

@qiujiayu qiujiayu commented Sep 26, 2024

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #81

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Summary by CodeRabbit

  • New Features

    • Added support for Spring Boot 3, enhancing compatibility with the latest framework version.
    • Improved auto-configuration capabilities for better integration with the Spring framework.
  • Bug Fixes

    • Resolved the "Cannot enhance @configuration bean definition" issue, improving functionality.

Copy link
Contributor

coderabbitai bot commented Sep 26, 2024

Walkthrough

The changes involve updating the CHANGES.md file to document support for Spring Boot 3 and modifying the ApolloAutoConfiguration class in the Apollo client library by replacing the @Configuration annotation with @AutoConfiguration. This indicates a shift towards auto-configuration within the Spring framework while retaining existing conditional annotations that control instantiation based on specific properties and beans.

Changes

File Change Summary
CHANGES.md Added entry for Spring Boot 3 support and linked to pull request #82.
apollo-client/src/main/java/com/ctrip/framework/apollo/spring/boot/ApolloAutoConfiguration.java Changed annotation from @Configuration to @AutoConfiguration in ApolloAutoConfiguration class.

Assessment against linked issues

Objective Addressed Explanation
Spring Boot 3.3.3 compatibility issue (#81)
Fix for "Cannot enhance @configuration bean" (#81)

🐰 In the code, a change so bright,
From @Configuration, we take flight.
With @AutoConfiguration, we now align,
Spring's embrace is truly divine!
Bugs be gone, let harmony reign,
In Apollo's world, we dance without pain! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1a542a0 and 3178239.

📒 Files selected for processing (1)
  • CHANGES.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGES.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Sep 26, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@qiujiayu
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Would you please also help to update the CHANGES.md?

@qiujiayu
Copy link
Contributor Author

Thanks. Would you please also help to update the CHANGES.md?

done

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGES.md (1)

8-8: LGTM! Consider adding more details to the changelog entry.

The new changelog entry correctly documents the support for Spring Boot 3 and provides a link to the relevant pull request. This aligns well with the PR objectives.

To provide more context for users, consider expanding the changelog entry to include:

  1. The specific version of Spring Boot 3 tested (3.3.3 as mentioned in the issue).
  2. A brief mention of the issue that was resolved (e.g., configuration bean definition enhancement error).

Here's a suggested expansion:

-* [support spring boot3](https://github.com/apolloconfig/apollo-java/pull/82)
+* [Add support for Spring Boot 3.x](https://github.com/apolloconfig/apollo-java/pull/82)
+  - Resolves configuration bean definition enhancement errors in Spring Boot 3.3.3
+  - Ensures compatibility with Spring Boot 3.x versions

This additional information would provide users with more context about the changes and the specific issues addressed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cbe695b and 1a542a0.

📒 Files selected for processing (2)
  • CHANGES.md (1 hunks)
  • apollo-client/src/main/java/com/ctrip/framework/apollo/spring/boot/ApolloAutoConfiguration.java (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apollo-client/src/main/java/com/ctrip/framework/apollo/spring/boot/ApolloAutoConfiguration.java

CHANGES.md Outdated Show resolved Hide resolved
@nobodyiam
Copy link
Member

As this is a warning message and occurs not only in spring boot 3 but also spring boot 2, I changed the description to Fix the Cannot enhance @Configuration bean definition issue.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 6405daa into apolloconfig:main Sep 30, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring boot 3.3.3 使用时报错
2 participants