Add support for RTL languages

natanfelles · natanfelles · commit df19d842b8d1 · 2025-06-30T22:39:52.000-03:00
diff --git a/src/Views/exceptions/development.php b/src/Views/exceptions/development.php
@@ -160,6 +160,11 @@
             border-right: 2px solid #222;
         }
 
+        .rtl th {
+            border-left: 2px solid #222;
+            border-right: 0;
+        }
+
         th, td {
             border-bottom: 1px solid #222;
             padding: 5px;
@@ -179,12 +184,21 @@
             text-align: left;
         }
 
+        .rtl thead th {
+            border-left: 0;
+            text-align: right;
+        }
+
         tbody th {
             background: #111;
             min-width: 40%;
             text-align: right;
         }
 
+        .rtl tbody th {
+            text-align: left;
+        }
+
         tbody tr:hover th,
         tr:hover {
             background: #333;
@@ -231,7 +245,7 @@
         }
     </style>
 </head>
-<body class="aplus-debug">
+<body class="aplus-debug <?= $handler->getLanguage()->getCurrentLocaleDirection() ?>">
 <header class="top">
     <small><?= $lang('exception') ?>:</small>
     <h1><?= $exception::class ?></h1>
@@ -279,7 +293,7 @@
     <?php foreach ($traces as $key => $trace) : ?>
         <?php if (isset($trace['file'])) : ?>
             <?php if (is_readable($trace['file'])) : ?>
-                <dl>
+                <dl dir="ltr">
                     <dt>
                         <span><?= count($traces) - $key ?></span>
                         <?= $trace['file'] ?><?=
@@ -410,7 +424,7 @@
             </tr>
             <tr>
                 <th><?= $lang('message') ?></th>
-                <td>
+                <td dir="ltr">
                     <pre><code class="language-log"><?= htmlentities($log->message) ?></code></pre>
                 </td>
             </tr>
diff --git a/src/Views/exceptions/production.php b/src/Views/exceptions/production.php
@@ -13,6 +13,7 @@
 };
 
 $log = $handler->getLog();
+$isRtl = $handler->getLanguage()->getCurrentLocaleDirection() === 'rtl';
 ?>
 <!doctype html>
 <html lang="<?= $handler->getLanguage()->getCurrentLocale() ?>" dir="<?= $handler->getLanguage()
@@ -52,10 +53,17 @@
 <h1><?= $lang('exceptionTitle') ?></h1>
 <p><?= $lang('exceptionDescription') ?></p>
 <?php if ($log) : ?>
-    <p><?= $lang('logId') ?>: <span class="log-id"
-            title="<?= htmlentities($lang('clickToCopyLogId')) ?>"
-        ><?= htmlentities($log->id) ?></span>
-    </p>
+    <?php if ($isRtl) : ?>
+        <p><span class="log-id"
+                title="<?= htmlentities($lang('clickToCopyLogId')) ?>"
+            ><?= htmlentities($log->id) ?></span> :<?= $lang('logId') ?>
+        </p>
+    <?php else : ?>
+        <p><?= $lang('logId') ?>: <span class="log-id"
+                title="<?= htmlentities($lang('clickToCopyLogId')) ?>"
+            ><?= htmlentities($log->id) ?></span>
+        </p>
+    <?php endif ?>
     <script>
         document.querySelector('.log-id').onclick = function () {
             navigator.clipboard.writeText(this.innerText);
diff --git a/tests/ExceptionHandlerTest.php b/tests/ExceptionHandlerTest.php
@@ -383,6 +383,50 @@ public function testAddAndRemoveHiddenInput() : void
         );
     }
 
+    /**
+     * @runInSeparateProcess
+     *
+     * @dataProvider environmentsProvider
+     */
+    public function testExceptionsWithLtrLanguage(string $environment) : void
+    {
+        $_POST = ['foo' => 'bar'];
+        $language = new Language('en', [__DIR__ . '/../src/Languages']);
+        $exceptions = new ExceptionHandlerMock(
+            $environment,
+            $this->getLogger(),
+            $language
+        );
+        $exceptions->cli = false;
+        $exceptions->setHiddenInputs('$_POST');
+        \ob_start();
+        $exceptions->exceptionHandler(new \Exception('Foo'));
+        $contents = (string) \ob_get_clean();
+        self::assertStringContainsString('dir="ltr"', $contents);
+    }
+
+    /**
+     * @runInSeparateProcess
+     *
+     * @dataProvider environmentsProvider
+     */
+    public function testExceptionsWithRtlLanguage(string $environment) : void
+    {
+        $_POST = ['foo' => 'bar'];
+        $language = new Language('he', [__DIR__ . '/../src/Languages']);
+        $exceptions = new ExceptionHandlerMock(
+            $environment,
+            $this->getLogger(),
+            $language
+        );
+        $exceptions->cli = false;
+        $exceptions->setHiddenInputs('$_POST');
+        \ob_start();
+        $exceptions->exceptionHandler(new \Exception('Foo'));
+        $contents = (string) \ob_get_clean();
+        self::assertStringContainsString('dir="rtl"', $contents);
+    }
+
     /**
      * @return array<array<string>>
      */
