chore(tests): use glob instead of walking files #380
Conversation
This patch removes the custom setup of running the files in the endpoints folders and instead uses the unix style globbing to find the tests files. This enables us to use builtin functions such as `describe.only` and `it.only` to only run a single test or suite at a time as well as enables us to maybe run tests in parallel.
koddsson
requested review from
benediktvaldez,
kristjanmik and
MiniGod
as code owners
| @@ -6,7 +6,7 @@ import defaultConfig from './default.json' | |||
|
|
|||
| const debug = makeDebug('config') | |||
|
|
|||
| let env = process.env.NODE_ENV ? `${process.env.NODE_ENV}.config` : 'dev.config' | |||
| let env = process.env.NODE_ENV | |||
There was a problem hiding this comment.
I think I'd like to clean up this whole config file in another PR and just use the config package as is. There seems like there's a lot of code here that can easily become bugs just like this.
Also the debug setup is due for a refactoring. The bug here wasn't being surfaced since it was being swallowed up in the debug.
There was a problem hiding this comment.
Yeah, this file is a bit messy. Only comment would be that there's a mention of dev.config.json on line 21 which is not valid any more, but doesn't matter if we clean up this file soon anyway.
| @@ -6,7 +6,7 @@ import defaultConfig from './default.json' | |||
|
|
|||
| const debug = makeDebug('config') | |||
|
|
|||
| let env = process.env.NODE_ENV ? `${process.env.NODE_ENV}.config` : 'dev.config' | |||
| let env = process.env.NODE_ENV | |||
There was a problem hiding this comment.
Yeah, this file is a bit messy. Only comment would be that there's a mention of dev.config.json on line 21 which is not valid any more, but doesn't matter if we clean up this file soon anyway.
This patch removes the custom setup of running the files in the endpoints
folders and instead uses the unix style globbing to find the tests files.
This enables us to use builtin functions such as
describe.onlyandit.onlyto only run a single test or suite at a time as well as enablesus to maybe run tests in parallel.