b/65101827 SF 1430625 - Analytics for Company APPs not working #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Company app analytics was not working properly because the call to analytics was filtering by developer. Removed filter from DeveloperAppAnalytics.getByAppName that was filtering by developer.
Contributor
|
Watch out. If you do not filter by developer, if you query |
Collaborator
Author
|
Thanks @ossobuffo ! I thought there was a reason that filter was there, but could not think of why. I will close this PR and look for a way to filter by company. I do not think it is possible however, since Edge analytics screens say "AppName by (not set)" when it is a company app, where "not set" should be the developer's name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Company app analytics was not working properly because the call to analytics was filtering by developer. Removed filter from DeveloperAppAnalytics.getByAppName that was filtering by developer.