Oauth support and a little refactoring #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth authentication.
- Reduced the number of parameters in the Client class. Original parameters still can be passed in the $options array. (However there is no BC provided while there is only dev version this is a BC break change.) - New dependency: symfony/options-resolver. - Made $client required in all API controllers. - Improved __toString() implementation on ApiException and in its child classes. - Instead of OauthResponseException, OauthAuthenticationException is being thrown every time when OAuth authentication fails. - API client can be changed in the OAuth authentication plugin by overriding the authClient() method. - Cache plugin specific support dropped from the Builder class because it was just an unnecessary overhead on our side. Cache plugin can be still added to the HTTP client by using addPlugin. - Cache plugin support also dropped from the Client, because caching on the HTTP requests level does not seem a good option because cache invalidation could become complicated. Instead, caching should be handled at the API controller level if it is needed.
namespace. (However there is no BC granted while there is only a dev version, this is a BC break change.)
Codecov Report
@@ Coverage Diff @@
## 2.x-dev #103 +/- ##
=============================================
+ Coverage 86.42% 87.37% +0.94%
- Complexity 515 534 +19
=============================================
Files 69 72 +3
Lines 1208 1251 +43
=============================================
+ Hits 1044 1093 +49
+ Misses 164 158 -6
Continue to review full report at Codecov.
|
peterserfozo
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.