Skip to content

Conversation

@mxr576
Copy link
Contributor

@mxr576 mxr576 commented May 3, 2018

No description provided.

mxr576 added 3 commits May 3, 2018 11:57
Signed-off-by: Dezső Biczó <mxr576@gmail.com>
Signed-off-by: Dezső Biczó <mxr576@gmail.com>
OAuth authentication.

Signed-off-by: Dezső Biczó <mxr576@gmail.com>
@mxr576 mxr576 requested review from cnovak, peterserfozo and tamasd May 3, 2018 10:19
@mxr576
Copy link
Contributor Author

mxr576 commented May 3, 2018

Tests are coming soon.
@cnovak I have just added you as a review to give you a chance to review this code before it gets merged. Let me know if you do not have resources for this.
Also an another question, should OAuth support be part of the alpha release or it should not?

@codecov-io
Copy link

codecov-io commented May 3, 2018

Codecov Report

Merging #102 into 2.x-dev will decrease coverage by 5.99%.
The diff coverage is 16.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             2.x-dev     #102   +/-   ##
==========================================
- Coverage      86.42%   80.42%   -6%     
- Complexity       515      562   +47     
==========================================
  Files             69       72    +3     
  Lines           1208     1303   +95     
==========================================
+ Hits            1044     1048    +4     
- Misses           164      255   +91
Impacted Files Coverage Δ Complexity Δ
...lugin/Authentication/InMemoryOauthTokenStorage.php 0% <0%> (ø) 21 <21> (?)
...tpClient/Plugin/RetryOauthAuthenticationPlugin.php 0% <0%> (ø) 7 <7> (?)
src/HttpClient/Plugin/Authentication/Oauth.php 0% <0%> (ø) 11 <11> (?)
src/Exception/ApiResponseException.php 69.56% <100%> (+2.89%) 13 <0> (+2) ⬆️
src/HttpClient/Plugin/ResponseHandlerPlugin.php 70.83% <14.28%> (-23.29%) 21 <0> (+4)
src/HttpClient/Client.php 85.88% <91.66%> (-1.33%) 35 <2> (+2)
src/HttpClient/Utility/Journal.php 60% <0%> (+20%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ddbe81...1ce7b70. Read the comment docs.

@mxr576
Copy link
Contributor Author

mxr576 commented May 7, 2018

Merged to the oauth branch.

@mxr576 mxr576 closed this May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants