address feedback

Author: vdusek

src/crawlee/_autoscaling/snapshotter.py

@@ -92,7 +92,7 @@ def __init__(
         self._reserve_memory_ratio = reserve_memory_ratio
         self._memory_warning_cooldown_period = memory_warning_cooldown_period
         self._client_rate_limit_error_retry_count = client_rate_limit_error_retry_count
-        self._max_memory_size = max_memory_size or self._get_default_max_memory_size(
+        self._max_memory_size = max_memory_size or self._determine_max_memory_size(
             config.memory_mbytes, self._available_memory_ratio
         )
         self._cpu_snapshots = self._get_sorted_list_by_created_at(list[CpuSnapshot]())
@@ -113,8 +113,12 @@ def _get_sorted_list_by_created_at(input_list: list[T]) -> SortedList[T]:
         return SortedList(input_list, key=attrgetter('created_at'))
 
     @staticmethod
-    def _get_default_max_memory_size(memory_mbytes: int | None, available_memory_ratio: float) -> ByteSize:
-        """If `memory_mbytes` is not provided, calculates the default `max_memory_size` based on the system memory."""
+    def _determine_max_memory_size(memory_mbytes: int | None, available_memory_ratio: float) -> ByteSize:
+        """Determine the maximum memory size for the current run.
+
+        If `memory_mbytes` is provided, it uses that value. Otherwise, it calculates the default `max_memory_size`
+        as a proportion of the system's total available memory based on `available_memory_ratio`.
+        """
         if memory_mbytes:
             return ByteSize.from_mb(memory_mbytes)
 

src/crawlee/events/_event_manager.py

@@ -68,7 +68,6 @@ def __init__(
 
         Args:
             persist_state_interval: Interval between emitted `PersistState` events to maintain state persistence.
-                The default value is taken from the `Configuration`.
             close_timeout: Optional timeout for canceling pending event listeners if they exceed this duration.
         """
         self._persist_state_interval = persist_state_interval

src/crawlee/events/_local_event_manager.py

@@ -33,12 +33,11 @@ def __init__(
     ) -> None:
         """A default constructor.
 
-        In the most cases you should use the `from_config` constructor to create an new instance based on
+        In most cases, you should use the `from_config` constructor to create a new instance based on
         the provided configuration.
 
         Args:
-            system_info_interval: Interval at which `SystemInfo` events are emitted. The default value is taken
-                from the `Configuration`.
+            system_info_interval: Interval at which `SystemInfo` events are emitted.
             event_manager_options: Additional options for the parent class.
         """
         self._system_info_interval = system_info_interval

src/crawlee/storage_clients/_memory/_memory_storage_client.py

@@ -68,7 +68,7 @@ def __init__(
     ) -> None:
         """A default constructor.
 
-        In the most cases you should use the `from_config` constructor to create an new instance based on
+        In most cases, you should use the `from_config` constructor to create a new instance based on
         the provided configuration.
 
         Args:

tests/unit/crawlers/_basic/test_basic_crawler.py

@@ -1005,10 +1005,7 @@ async def handler(context: BasicCrawlingContext) -> None:
 
 async def test_sets_services() -> None:
     custom_configuration = Configuration()
-    custom_event_manager = LocalEventManager(
-        system_info_interval=timedelta(seconds=3),
-        persist_state_interval=timedelta(seconds=30),
-    )
+    custom_event_manager = LocalEventManager.from_config(custom_configuration)
     custom_storage_client = MemoryStorageClient.from_config(custom_configuration)
 
     crawler = BasicCrawler(