Skip to content

Commit 44bc85a

Browse files
authored
chore: Fix flaky tests for SitemapRequestLoader (#1717)
1 parent 4f4f7bc commit 44bc85a

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

tests/unit/request_loaders/test_sitemap_request_loader.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ async def test_sitemap_traversal(server_url: URL, http_client: HttpClient) -> No
5656

5757
while not await sitemap_loader.is_finished():
5858
item = await sitemap_loader.fetch_next_request()
59-
assert item is not None
6059

61-
await sitemap_loader.mark_request_as_handled(item)
60+
if item:
61+
await sitemap_loader.mark_request_as_handled(item)
6262

6363
assert await sitemap_loader.is_empty()
6464
assert await sitemap_loader.is_finished()
@@ -85,6 +85,9 @@ async def test_is_empty_does_not_depend_on_fetch_next_request(server_url: URL, h
8585
await sitemap_loader.mark_request_as_handled(item)
8686

8787
assert await sitemap_loader.is_empty()
88+
89+
await asyncio.sleep(0.1)
90+
8891
assert await sitemap_loader.is_finished()
8992

9093

@@ -192,12 +195,13 @@ def transform_request(request_options: RequestOptions) -> RequestOptions | Reque
192195

193196
while not await sitemap_loader.is_finished():
194197
request = await sitemap_loader.fetch_next_request()
195-
assert request is not None
196-
assert request.user_data.get('transformed') is True
197198

198-
extracted_urls.add(request.url)
199+
if request:
200+
assert request.user_data.get('transformed') is True
201+
202+
extracted_urls.add(request.url)
199203

200-
await sitemap_loader.mark_request_as_handled(request)
204+
await sitemap_loader.mark_request_as_handled(request)
201205

202206
assert len(extracted_urls) == 5
203207
assert extracted_urls == {

0 commit comments

Comments
 (0)