chore: reduce number of dependencies of utilities package

Author: B4nan

package-lock.json

@@ -46,7 +46,7 @@
     },
     "lint-staged": {
         "*.ts": [
-            "eslint packages/*/src --fix"
+            "eslint packages/*/src/**/*.ts --fix"
         ]
     },
     "devDependencies": {

package.json

@@ -49,12 +49,9 @@
         "ajv": "^6.12.6",
         "countries-list": "^2.6.1",
         "create-hmac": "^1.1.7",
-        "cherow": "^1.6.9",
-        "is-buffer": "^2.0.5",
-        "request": "^2.88.2"
+        "cherow": "^1.6.9"
     },
     "devDependencies": {
-        "@types/create-hmac": "^1.1.0",
-        "@types/request": "^2.48.5"
+        "@types/create-hmac": "^1.1.0"
     }
 }

packages/utilities/package.json

@@ -6,7 +6,6 @@
  *
  */
 
-import isBuffer from 'is-buffer';
 import { countries } from 'countries-list';
 import { VERSION_INT_MAJOR_BASE, VERSION_INT_MINOR_BASE, PROXY_URL_REGEX, URL_REGEX, RELATIVE_URL_REGEX } from '@apify/consts';
 import { m, parseAjvError } from '@apify/input_schema';
@@ -19,6 +18,10 @@ export function isNullOrUndefined(obj: unknown): boolean {
     return obj == null;
 }
 
+export function isBuffer(obj: any): boolean {
+    return obj != null && obj.constructor != null && typeof obj.constructor.isBuffer === 'function' && obj.constructor.isBuffer(obj);
+}
+
 /**
  * Converts Date object to ISO string.
  */

packages/utilities/src/utilities.client.ts

@@ -8,7 +8,6 @@
  */
 
 import crypto from 'crypto';
-import request, { CoreOptions, Response } from 'request';
 import log, { Logger, LoggerJson, LogLevel } from '@apify/log';
 import { ANONYMOUS_USERNAME } from '@apify/consts';
 
@@ -190,31 +189,6 @@ export function weightedAverage(val1: number, weight1: number, val2: number, wei
     return (val1 * weight1 + val2 * weight2) / (weight1 + weight2);
 }
 
-/**
- * Promised version of request() library.
- * @param opts Options object for request() function.
- * @param failOnHttpError If true-ish, the function rejects the promise
- * if HTTP status is in the range 4XX or 5XX.
- * @return
- */
-export function requestPromised(opts: CoreOptions, failOnHttpError?: boolean): Promise<any> {
-    // TODO: Add unit test for this !!!
-    //  (edit: better to get rid of deprecated `request` and pick something with promise support baked in)
-    return new Promise(((resolve, reject) => {
-        request(opts as any, (error: Error, response: Response, body: any) => {
-            if (error) return reject(error);
-            if (failOnHttpError && response.statusCode >= 400 && response.statusCode <= 599) {
-                const err = new Error(`Received HTTP error response status ${response.statusCode}`) as any;
-                err.statusCode = response.statusCode;
-                err.body = body;
-
-                return reject(err);
-            }
-            resolve({ body, response, statusCode: response.statusCode });
-        });
-    }));
-}
-
 /**
  * List of forbidden usernames. Note that usernames can be used as apify.com/username,
  * so we need to prohibit any username that might be part of our website or confusing in anyway.