Skip to content

refactor!: Remove Request.id field #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 22, 2025
Merged

refactor!: Remove Request.id field #553

merged 7 commits into from
Aug 22, 2025

Conversation

@Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Aug 19, 2025 •
edited
Loading

Description

Issues

@github-actions github-actions bot added this to the 121st sprint - Tooling team milestone Aug 19, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Aug 19, 2025
@Pijukatel Pijukatel changed the title Remove request.id feat: Remove request.id Aug 20, 2025
Pijukatel
Pijukatel commented Aug 20, 2025
View reviewed changes
Pijukatel
Pijukatel commented Aug 20, 2025
View reviewed changes
@Pijukatel Pijukatel requested review from janbuchar and vdusek August 20, 2025 08:05
@Pijukatel Pijukatel marked this pull request as ready for review August 20, 2025 08:05
vdusek
vdusek reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, let's wait for the downstream repo PRs.

@B4nan
Copy link
Member

B4nan commented Aug 20, 2025

this doesnt sound much like a feature to me 🙃 i'd call it a fix or a refactor

@Pijukatel Pijukatel changed the title feat: Remove request.id refactor!: Remove request.id Aug 20, 2025
@Pijukatel Pijukatel marked this pull request as draft August 20, 2025 14:14
@Pijukatel
Move transformation function to from client to sdk
caf9e23 
Update leftover id-based variable names
@Pijukatel Pijukatel marked this pull request as ready for review August 21, 2025 15:40
@Pijukatel
Copy link
Contributor Author

Failing docs are unrelated to this change. See apify/apify-docs#1822 (comment)

@Pijukatel Pijukatel requested a review from vdusek August 21, 2025 15:41
@vdusek vdusek changed the title refactor!: Remove request.id refactor!: Remove Request.id field Aug 22, 2025
vdusek
vdusek reviewed Aug 22, 2025
View reviewed changes
vdusek
vdusek approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment, otherwise, lgtm

@Pijukatel Pijukatel merged commit 445ab5d into master Aug 22, 2025
22 of 23 checks passed
@Pijukatel Pijukatel deleted the remove-request-id branch August 22, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

@janbuchar janbuchar Awaiting requested review from janbuchar

Assignees

@Pijukatel Pijukatel

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

121st sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

4 participants

@Pijukatel @B4nan @vdusek