-
Notifications
You must be signed in to change notification settings - Fork 98
feat(widget): setup shared Apify libraries #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| import "../index.css"; | ||
| import React from "react"; | ||
| import { UiDependencyProvider } from "@apify/ui-library"; | ||
| import { tokens as lightCssVariables } from "@apify/ui-library/dist/src/design_system/colors/generated/css_variables.light.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ugly. No other way to do this for now.
If we have time and we need to modify ui-library for this job, we could export this with buckets properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baldasseva I'm not sure about this; I tried with normal
import { UiDependencyProvider, cssColorsVariablesLight, cssColorsVariablesDark } from "@apify/ui-library";
and I see the variables when checking http://localhost:3000/index.html

is this what we're trying to do here (?) 😅
| const link1 = document.createElement("link"); | ||
| link1.id = "apify-fonts-preconnect-1"; | ||
| link1.rel = "preconnect"; | ||
| link1.href = "https://fonts.googleapis.com"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure the fonts are loading because the heading looks ugly XD
MQ37
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, blazingly fast onboarding B) Only the gray "shadow" above the Actor card looks a bit weird to me, otherwise great stuff.
katacek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot! 👏
The changes that I did here look something like this:
That's our shared card component, just to check that it works.
From now on, we can work to update the UI with our components.
The Search results text should be using our typography. Not sure that it does... But we'll check that out later
Also it doesn't go into dark mode. Probably we need to tweak something to let it notice that we are going into dark mode. Will look into it in the next days, I guess.
I've added too many people for review, but it's FYI.