Skip to content

Conversation

@baldasseva
Copy link
Contributor

The changes that I did here look something like this:

image

That's our shared card component, just to check that it works.
From now on, we can work to update the UI with our components.
The Search results text should be using our typography. Not sure that it does... But we'll check that out later
Also it doesn't go into dark mode. Probably we need to tweak something to let it notice that we are going into dark mode. Will look into it in the next days, I guess.

I've added too many people for review, but it's FYI.

@baldasseva baldasseva added the adhoc Ad-hoc unplanned task added during the sprint. label Jan 28, 2026
@github-actions github-actions bot added the t-discovery Issues owned by the discovery team. label Jan 28, 2026
import "../index.css";
import React from "react";
import { UiDependencyProvider } from "@apify/ui-library";
import { tokens as lightCssVariables } from "@apify/ui-library/dist/src/design_system/colors/generated/css_variables.light.js";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ugly. No other way to do this for now.

If we have time and we need to modify ui-library for this job, we could export this with buckets properly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baldasseva I'm not sure about this; I tried with normal

import { UiDependencyProvider, cssColorsVariablesLight, cssColorsVariablesDark } from "@apify/ui-library";

and I see the variables when checking http://localhost:3000/index.html
image

is this what we're trying to do here (?) 😅

const link1 = document.createElement("link");
link1.id = "apify-fonts-preconnect-1";
link1.rel = "preconnect";
link1.href = "https://fonts.googleapis.com";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the fonts are loading because the heading looks ugly XD

Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, blazingly fast onboarding B) Only the gray "shadow" above the Actor card looks a bit weird to me, otherwise great stuff.

Copy link
Member

@katacek katacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot! 👏

@baldasseva baldasseva merged commit 69492c0 into master Jan 29, 2026
5 checks passed
@baldasseva baldasseva deleted the feat/setup-shared-apify-components branch January 29, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-discovery Issues owned by the discovery team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants