-
Notifications
You must be signed in to change notification settings - Fork 104
docs: rename Academy articles #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Rename to avoid confusion & make titles more action-oriented
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
@@ -57,7 +55,7 @@ One important thing to note is that you can use a `.gitignore` file to exclude f | |||
|
|||
## Deployed! {#deployed} | |||
|
|||
Great! Once you've pushed your Actor to the platform, you should see it in the list of Actors under the **Actors** tab. If you used `apify push`, you'll have access to the **multifile editor** (discussed [here](../getting_started/creating_actors.md)). | |||
Great! Once you've pushed your Actor to the platform, you should see it in the list of Actors under the **Actors** tab. If you used `apify push`, you'll have access to the **multifile editor** (discussed in [Creating Actors](../getting_started/creating_actors.md)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nicer to have the hyperlink directly underneath the text instead of having a clause with "discussed in X" or "discussed here".
Also, when I open the page, there's nothing about a multifile editor. As a reader (and even as an Apify emploee), I don't know what that is from that page, so the link doesn't really help me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the link to speficially go to #web-ide section of the Creating Actors page. But anything more would require a big rewrite, which is not the point of this change. I can attempt it but this will balloon this rather simple PR into something much more substantial
@@ -20,7 +18,7 @@ The **Dockerfile** is a file which gives the Apify platform (or Docker, more spe | |||
## Base images {#base-images} | |||
|
|||
If your project doesn’t already contain a Dockerfile, don’t worry! Apify offers [many base images](/sdk/js/docs/guides/docker-images) that are optimized for building and running Actors on the platform, which can be found [here](https://hub.docker.com/u/apify). When using a language for which Apify doesn't provide a base image, [Docker Hub](https://hub.docker.com/) provides a ton of free Docker images for most use-cases, upon which you can create your own images. | |||
If your project doesn’t already contain a Dockerfile, don’t worry! Apify offers [many base images](/sdk/js/docs/guides/docker-images) that are optimized for building and running Actors on the platform, which can be found on [Docker Hub](https://hub.docker.com/u/apify). When using a language for which Apify doesn't provide a base image, [Docker Hub](https://hub.docker.com/) provides a ton of free Docker images for most use-cases, upon which you can create your own images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double space "found on Docker Hub"
@@ -1,13 +1,11 @@ | |||
--- | |||
title: Deploying | |||
description: Push local code to the platform, or create a new Actor on the console and integrate it with a Git repo to optionally automatically rebuild any new changes. | |||
title: How to deploy your Actor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a pattern of naming articles with "how to"? I'm not 100% sure, but I'd keep the general approach of "ing ", so in this case, Deploying your Actor, and similarly the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is special case as the article for input schema is named same as the one in platform docs. You can see context for the change in this discussion. But after changing one, it felt way out of place so it made sense to me to rename the whole section with similar style for consistency. This is temporary solution until Apify Platform section is dealt with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho naming articles "how to" is okay. see
Preview for this PR was built for commit |
Rename to avoid confusion & make titles more action-oriented