Fix tests doctrine deprecation #2098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jul 13, 2018
teohhanhui
reviewed
Jul 13, 2018
| @@ -14,8 +14,6 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=7.1", | |||
|
|
|||
| "doctrine/inflector": "^1.0", | |||
|
Could you please merge this into branch v2.2 as well? We are stuck with symfony 3.4 on our project, so we cannot use version 2.3 of API platform (it requires symfony serializer 4.1). And in our logs we get all the time this annoying: |
|
WDYT @dunglas should we patch this on 2.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dunglas I think that the ClassLoader is used by symfony in https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Test/DoctrineTestHelper.php#L56 if that's not the case I don't get it (see DoctrineOrmFilterTestCase).
I'm really not sure how we can fix those deprecations right now.