Skip to content

Merge 2.2 into master #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 2, 2018
Merged

Merge 2.2 into master #1917

merged 19 commits into from
May 2, 2018

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented May 2, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Necessary to unblock PRs that target master, because the CircleCI build would be failing otherwise. Replaces #1909.

Also, since we've messed up the 2.2 branch by accidentally merging in master in #1850, we need everything to be merged into master before it is safe to clean up the 2.2 branch.

teohhanhui and others added 19 commits April 26, 2018 00:12
add some local caches where they are missing
Allow subresource items in the iri converter
…keys

fix normalizer cache key generation
…force-eager

EagerLoadingExtension: respect fetchEager=false on an association
…-casting

[Bug] Fix integer Identifiers denormalization
…mplify-boolean-filter

Revert "Simplify boolean filter"
@antograssiot
Copy link
Contributor

That explains #1899 (comment)
This PR should not have been merged in 2.2 but master only then as I thought in the first place

@soyuka soyuka merged commit 1c3910b into api-platform:master May 2, 2018
@soyuka
Copy link
Member

soyuka commented May 2, 2018

Thanks @teohhanhui ! What do we need to do to fix 2.2?

@teohhanhui
Copy link
Contributor Author

@soyuka My suggestion in #1850 (comment). Not sure if there's a better way?

@teohhanhui
Copy link
Contributor Author

But I think my assertion that we need to merge 2.2 into master before we could clean it up was unfounded. Haha...

@teohhanhui teohhanhui deleted the merge-2.2 branch May 2, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants