Allow ordering on nested property values

Author: antograssiot

features/doctrine/order_filter.feature

@@ -830,3 +830,55 @@ Feature: Order filter on collections
       }
     }
     """
+
+  @createSchema
+  Scenario: Get collection ordered in descending order on a related property
+    Given there are 2 dummy objects with relatedDummy
+    When I send a "GET" request to "/dummies?order[relatedDummy.name]=desc"
+    Then the response status code should be 200
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+    And the JSON should be valid according to this schema:
+    """
+    {
+      "type": "object",
+      "properties": {
+        "@context": {"pattern": "^/contexts/Dummy$"},
+        "@id": {"pattern": "^/dummies$"},
+        "@type": {"pattern": "^hydra:Collection$"},
+        "hydra:member": {
+          "type": "array",
+          "items": [
+            {
+              "type": "object",
+              "properties": {
+                "@id": {
+                  "type": "string",
+                  "pattern": "^/dummies/2$"
+                }
+              }
+            },
+            {
+              "type": "object",
+              "properties": {
+                "@id": {
+                  "type": "string",
+                  "pattern": "^/dummies/1$"
+                }
+              }
+            }
+          ],
+          "additionalItems": false,
+          "maxItems": 2,
+          "minItems": 2
+        },
+        "hydra:view": {
+          "type": "object",
+          "properties": {
+            "@id": {"pattern": "^/dummies\\?order%5BrelatedDummy.name%5D=desc"},
+            "@type": {"pattern": "^hydra:PartialCollectionView$"}
+          }
+        }
+      }
+    }
+    """

features/graphql/filters.feature

@@ -93,11 +93,6 @@ Feature: Collections filtering
   Scenario: Retrieve a collection filtered using the related search filter
     Given there are 1 dummy objects having each 2 relatedDummies
     And there are 1 dummy objects having each 3 relatedDummies
-    When I add "Accept" header equal to "application/hal+json"
-    And I send a "GET" request to "/dummies?relatedDummies.name=RelatedDummy31"
-    Then the response status code should be 200
-    And the response should be in JSON
-    And the JSON node "_embedded.item" should have 1 element
     When I send the following GraphQL request:
     """
     {
@@ -112,3 +107,27 @@ Feature: Collections filtering
     """
     And the response status code should be 200
     And the JSON node "data.dummies.edges" should have 1 element
+
+  @createSchema
+  Scenario: Retrieve a collection ordered using nested properties
+    Given there are 2 dummy objects with relatedDummy
+    When I send the following GraphQL request:
+    """
+    {
+      dummies(order: {relatedDummy_name: "DESC"}) {
+        edges {
+          node {
+            name
+            relatedDummy {
+              id
+              name
+            }
+          }
+        }
+      }
+    }
+    """
+    Then the response status code should be 200
+    And the header "Content-Type" should be equal to "application/json"
+    And the JSON node "data.dummies.edges[0].node.name" should be equal to "Dummy #2"
+    And the JSON node "data.dummies.edges[1].node.name" should be equal to "Dummy #1"

src/GraphQl/Resolver/Factory/CollectionResolverFactory.php

@@ -77,14 +77,7 @@ public function __invoke(string $resourceClass = null, string $rootClass = null,
             $resourceMetadata = $this->resourceMetadataFactory->create($resourceClass);
             $dataProviderContext = $resourceMetadata->getGraphqlAttribute('query', 'normalization_context', [], true);
             $dataProviderContext['attributes'] = $this->fieldsToAttributes($info);
-            $filters = $args;
-            foreach ($filters as $name => $value) {
-                if (strpos($name, '_')) {
-                    // Gives a chance to relations/nested fields
-                    $filters[str_replace('_', '.', $name)] = $value;
-                }
-            }
-            $dataProviderContext['filters'] = $filters;
+            $dataProviderContext['filters'] = $this->getNormalizedFilters($args);
 
             if (isset($rootClass, $source[$rootProperty = $info->fieldName], $source[ItemNormalizer::ITEM_KEY])) {
                 $rootResolvedFields = $this->identifiersExtractor->getIdentifiersFromItem(unserialize($source[ItemNormalizer::ITEM_KEY]));
@@ -171,4 +164,22 @@ private function getSubresource(string $rootClass, array $rootResolvedFields, ar
             'collection' => $isCollection,
         ]);
     }
+
+    private function getNormalizedFilters(array $args): array
+    {
+        $filters = $args;
+        foreach ($filters as $name => $value) {
+            if (\is_array($value)) {
+                $filters[$name] = $this->getNormalizedFilters($value);
+                continue;
+            }
+
+            if (strpos($name, '_')) {
+                // Gives a chance to relations/nested fields.
+                $filters[str_replace('_', '.', $name)] = $value;
+            }
+        }
+
+        return $filters;
+    }
 }

src/GraphQl/Type/SchemaBuilder.php

@@ -291,6 +291,13 @@ private function mergeFilterArgs(array $args, array $parsed, ResourceMetadata $r
 
     private function convertFilterArgsToTypes(array $args): array
     {
+        foreach ($args as $key => $value) {
+            if (strpos($key, '.')) {
+                // Declare relations/nested fields in a GraphQL compatible syntax.
+                $args[str_replace('.', '_', $key)] = $value;
+            }
+        }
+
         foreach ($args as $key => $value) {
             if (!\is_array($value) || !isset($value['#name'])) {
                 continue;