Merge pull request #2089 from mauchede/fix/cache-tags-for-subresources

Add subresource collection to Cache-Tags

Author: soyuka

src/HttpCache/EventListener/AddTagsListener.php

@@ -56,7 +56,7 @@ public function onKernelResponse(FilterResponseEvent $event)
         }
 
         $resources = $request->attributes->get('_resources');
-        if (isset($attributes['collection_operation_name'])) {
+        if (isset($attributes['collection_operation_name']) || ($attributes['subresource_context']['collection'] ?? false)) {
             // Allows to purge collections
             $iri = $this->iriConverter->getIriFromResourceClass($attributes['resource_class']);
             $resources[$iri] = $iri;

tests/HttpCache/EventListener/AddTagsListenerTest.php

@@ -166,4 +166,25 @@ public function testAddCollectionIriWhenCollectionIsEmpty()
 
         $this->assertSame('/dummies', $response->headers->get('Cache-Tags'));
     }
+
+    public function testAddSubResourceCollectionIri()
+    {
+        $iriConverterProphecy = $this->prophesize(IriConverterInterface::class);
+        $iriConverterProphecy->getIriFromResourceClass(Dummy::class)->willReturn('/dummies')->shouldBeCalled();
+
+        $request = new Request([], [], ['_resources' => ['/foo', '/bar'], '_api_resource_class' => Dummy::class, '_api_subresource_operation_name' => 'api_dummies_relatedDummies_get_subresource', '_api_subresource_context' => ['collection' => true]]);
+
+        $response = new Response();
+        $response->setPublic();
+        $response->setEtag('foo');
+
+        $event = $this->prophesize(FilterResponseEvent::class);
+        $event->getRequest()->willReturn($request)->shouldBeCalled();
+        $event->getResponse()->willReturn($response)->shouldBeCalled();
+
+        $listener = new AddTagsListener($iriConverterProphecy->reveal());
+        $listener->onKernelResponse($event->reveal());
+
+        $this->assertSame('/foo,/bar,/dummies', $response->headers->get('Cache-Tags'));
+    }
 }