fix: inconsistencies between dark and light theme override (#487)

* fix: inconsistencies between dark and light theme override

* fix(hydra): add array check for @id

* test: fix tests after 4.4.2

* chore: update CHANGELOG

Co-authored-by: Alan Poulain <contact@alanpoulain.eu>

Author: fsidobre

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 3.4.3
+
+* Fix inconsistencies between dark and light theme
+
 ## 3.4.2
 
 * Format identifier values on save (needed when not modified in the form)

src/InputGuesser.test.tsx

@@ -170,8 +170,8 @@ describe('<InputGuesser />', () => {
     await waitFor(() => {
       expect(updatedData).toMatchObject({
         title: 'Title Foo',
-        description: '',
-        nullText: '',
+        description: null,
+        nullText: null,
       });
     });
   });

src/hydra/dataProvider.ts

@@ -57,6 +57,9 @@ class ReactAdminDocument implements ApiPlatformAdminRecord {
     if (!obj['@id']) {
       throw new Error('Document needs to have an @id member.');
     }
+    if (Array.isArray(obj['@id'])) {
+      throw new Error('Document needs to have a string @id member.');
+    }
     this.id = obj['@id'];
   }
 
@@ -117,7 +120,7 @@ export const transformJsonLdDocumentToReactAdminDocument = (
       document[key][0]['@id']
     ) {
       document[key] = document[key].map((obj: JsonLdObj) => {
-        if (addToCache && obj['@id']) {
+        if (addToCache && obj['@id'] && !Array.isArray(obj['@id'])) {
           reactAdminDocumentsCache.set(
             obj['@id'],
             transformJsonLdDocumentToReactAdminDocument(obj, false, false),

src/layout/themes.ts

@@ -54,6 +54,7 @@ export const lightTheme: RaThemeOptions = {
     mode: 'light',
   },
   components: {
+    ...defaultTheme.components,
     // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore react-admin doesn't add its own components
     RaMenuItemLink: {