Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration merging logic is incorrect #61

Open
maxb opened this issue Jan 19, 2014 · 1 comment
Open

Configuration merging logic is incorrect #61

maxb opened this issue Jan 19, 2014 · 1 comment

Comments

@maxb
Copy link

maxb commented Jan 19, 2014

Whilst reading the code, I noticed a problem with the configuration merging logic.

Consider the case of setting something to a non-default value in the main server configuration and then wanting to override it to the value that happens to be the default for that setting in a .

Since for non-pointer types the current code does not track the difference between "explicitly set to default value" and "not set so using default value", the merging logic cannot take account of this and will incorrectly ignore the inner scope's setting.

@dhawes
Copy link
Contributor

dhawes commented Feb 6, 2020

I can verify that the situation you explain exists (tested with CASAttributePrefix). That said, I have never seen any issues reported because of this.

The fix seems easy enough, but I'll have to look at it a little closer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants