-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced all instances of 'python' with 'python2' #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On systems where 'python' refers to python3, redo failed to launch. All invocations of python have been made explicitly python2 invocations. All tests pass on an Arch Linux system as of this commit.
Yeah, okay. I guess it's time for that :) |
Thanks for this! It also helps when running You missed one though - redo-log still has just |
Hmm. The unit tests passed. I will take a look tonight. Maybe a new unit test is needed.
…Sent from my iPhone
On Nov 20, 2018, at 10:50 AM, Thomas Smith ***@***.***> wrote:
Thanks for this! It also helps when running redo while a python 3 virtualenv is activated.
You missed one though - redo-log still has just python
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
redo-log hadn't been merged at the time you made your patch, and I missed
it when combining the two. I'll add it :)
On Tue, Nov 20, 2018 at 2:35 PM Seamus Connor <notifications@github.com>
wrote:
… Hmm. The unit tests passed. I will take a look tonight. Maybe a new unit
test is needed.
Sent from my iPhone
> On Nov 20, 2018, at 10:50 AM, Thomas Smith ***@***.***>
wrote:
>
> Thanks for this! It also helps when running redo while a python 3
virtualenv is activated.
>
> You missed one though - redo-log still has just python
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABQcHicjbKdMYV_AjgsIpyMJsjai5M8ks5uxFl4gaJpZM4YeXfQ>
.
|
...and I've pushed a fix to master.
…On Tue, Nov 20, 2018 at 2:43 PM Avery Pennarun ***@***.***> wrote:
redo-log hadn't been merged at the time you made your patch, and I missed
it when combining the two. I'll add it :)
On Tue, Nov 20, 2018 at 2:35 PM Seamus Connor ***@***.***>
wrote:
> Hmm. The unit tests passed. I will take a look tonight. Maybe a new unit
> test is needed.
>
> Sent from my iPhone
>
> > On Nov 20, 2018, at 10:50 AM, Thomas Smith ***@***.***>
> wrote:
> >
> > Thanks for this! It also helps when running redo while a python 3
> virtualenv is activated.
> >
> > You missed one though - redo-log still has just python
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub, or mute the thread.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#22 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AABQcHicjbKdMYV_AjgsIpyMJsjai5M8ks5uxFl4gaJpZM4YeXfQ>
> .
>
|
Ahh, thanks.
…Sent from my iPhone
On Nov 20, 2018, at 11:43 AM, apenwarr ***@***.***> wrote:
redo-log hadn't been merged at the time you made your patch, and I missed
it when combining the two. I'll add it :)
On Tue, Nov 20, 2018 at 2:35 PM Seamus Connor ***@***.***>
wrote:
> Hmm. The unit tests passed. I will take a look tonight. Maybe a new unit
> test is needed.
>
> Sent from my iPhone
>
> > On Nov 20, 2018, at 10:50 AM, Thomas Smith ***@***.***>
> wrote:
> >
> > Thanks for this! It also helps when running redo while a python 3
> virtualenv is activated.
> >
> > You missed one though - redo-log still has just python
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub, or mute the thread.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#22 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AABQcHicjbKdMYV_AjgsIpyMJsjai5M8ks5uxFl4gaJpZM4YeXfQ>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thank you! :)
On Tue, Nov 20, 2018 at 4:51 PM Seamus Connor <notifications@github.com>
wrote:
… Ahh, thanks.
Sent from my iPhone
> On Nov 20, 2018, at 11:43 AM, apenwarr ***@***.***> wrote:
>
> redo-log hadn't been merged at the time you made your patch, and I missed
> it when combining the two. I'll add it :)
>
> On Tue, Nov 20, 2018 at 2:35 PM Seamus Connor ***@***.***>
> wrote:
>
> > Hmm. The unit tests passed. I will take a look tonight. Maybe a new
unit
> > test is needed.
> >
> > Sent from my iPhone
> >
> > > On Nov 20, 2018, at 10:50 AM, Thomas Smith ***@***.***
>
> > wrote:
> > >
> > > Thanks for this! It also helps when running redo while a python 3
> > virtualenv is activated.
> > >
> > > You missed one though - redo-log still has just python
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub, or mute the thread.
> >
> > —
> > You are receiving this because you modified the open/close state.
> > Reply to this email directly, view it on GitHub
> > <#22 (comment)>, or
mute
> > the thread
> > <
https://github.com/notifications/unsubscribe-auth/AABQcHicjbKdMYV_AjgsIpyMJsjai5M8ks5uxFl4gaJpZM4YeXfQ
>
> > .
> >
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAOAfmJM7SVtMQdsuIy03XbgWvtyN_CEks5uxHlqgaJpZM4YeXfQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems where 'python' refers to python3, redo
failed to launch. All invocations of python have been
made explicitly python2 invocations. All tests pass
on an Arch Linux system as of this commit.