Skip to content

Commit c0bff7b

Browse files
committed
more changes for domains and command consistency
1 parent d598727 commit c0bff7b

File tree

9 files changed

+23
-25
lines changed

9 files changed

+23
-25
lines changed

docker/nginx/m-hosts.conf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ map $http_host $MAGE_RUN_CODE {
2121
map $http_host $PHP_HOSTM2 {
2222
hostnames;
2323

24-
eg-m2-opensource.local php81;
25-
eg-m2-commerce.local php81;
24+
eg-m2-opensource.loc php81;
25+
eg-m2-commerce.loc php81;
2626
phpmyadmin.loc php82;
2727
docker-stack-ui.loc php82;
2828
titans.loc php81;

project/includes/_functions_m2.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# Magento 2 needs certain directories to work properly.
1414
# Create them if they're missing.
1515
#######################################################
16-
required_dirs_create () {
16+
internal_required_dirs_create () {
1717
# Phase ths step should run at.
1818
if [ $START_PHASE -gt 1 ] ; then
1919
echo_info "[!!] Skipping M2 directory fixes ...";

project/includes/_functions_shared.sh

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ files : Download the codebase, run any additional commands to get the code st
4141
database : Downloads a copy of the database and configuration then loads these into the correct container.
4242
install : Any final tasks required to get make the codebase operational e.g. composer or bin/magento
4343
44-
<start_phase> supported options :: [files, database, install, all]
44+
<start_phase> supported options ::
4545
4646
setup:all = file, database and install phase functions
47-
setup:database = database and install phase functions
47+
setup:database = database and install phase functions ONLY
4848
setup:install = install phase functions ONLY
4949
5050
<custom_function> supported options ::
@@ -125,8 +125,6 @@ internal_verify_auth_json () {
125125
if [ "${AUTH_JSON_IS_DEFAULT}" -ne 0 ]; then
126126
echo_error "Please add your credentials in $AUTH_JSON_FILE";
127127
exit 1;
128-
else
129-
echo_info "AUTH JSON IS FINE";
130128
fi
131129
fi
132130
}
@@ -319,9 +317,9 @@ IDE:vscode () {
319317
####################################
320318
# Please add host entry.
321319
#
322-
# VSCode will be available when the
323-
# docker build service informs of the
324-
# 0.0.0.0 URl being available on this URL.
320+
# When the Docker build process states
321+
# 0.0.0.0 URL is available, access:
322+
# http://vscode.loc
325323
#
326324
# MAC/LINUX:
327325
# 127.0.0.1 vscode.loc
@@ -342,7 +340,7 @@ IDE:vscode () {
342340
# $project_name
343341
# $vmhost_name
344342
######################################
345-
repository_clone () {
343+
repository:clone () {
346344
# Phase ths step should run at.
347345
if [ ${START_PHASE} -gt 1 ] ; then
348346
echo_warn "[!!] Skipping ${repo_type} clone ...";

project/m2_commerce

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ php_host='php81'; # 'php56', 'php70', 'php72', 'php73' or 'php74'
3030
required_containers=( "nginx" "rediscache" "redissession" "redisfullpage" "elasticsearch7" "${php_host}" "${db_host}");
3131
composer_version="2";
3232
db_name='example_m2_commerce'; # unique name for this database
33-
vmhost_name='eg-m2-commerce.local'; # domain name for this project in local vm.
33+
vmhost_name='eg-m2-commerce.loc'; # domain name for this project in local vm.
3434

3535
####################################
3636
# FUNCTIONS SPECIFIC TO THIS INSTALL
3737
####################################
38-
repository_clone () {
38+
repository:clone () {
3939
# Phase ths step should run at.
4040
if [ ${START_PHASE} -gt 1 ] ; then
4141
echo_warn "[!!] Skipping ${project_name} build ...";
@@ -84,8 +84,8 @@ internal_verify_required_containers_are_up;
8484
############################
8585

8686
recreate_database;
87-
repository_clone;
88-
required_dirs_create ;
87+
repository:clone;
88+
internal_required_dirs_create ;
8989

9090
## For Commerce, doing this rather than storing a DB and config as it was causing issues.
9191
bin/magento setup:install --base-url=https://${vmhost_name}/ \

project/m2_opensource

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ php_host='php81'; # 'php56', 'php70', 'php72', 'php73' or 'php74'
3030
required_containers=( "nginx" "rediscache" "redissession" "redisfullpage" "elasticsearch7" "${php_host}" "${db_host}");
3131
composer_version="2";
3232
db_name='example_m2_opensource'; # unique name for this database
33-
vmhost_name='eg-m2-opensource.local'; # domain name for this project in local vm.
33+
vmhost_name='eg-m2-opensource.loc'; # domain name for this project in local vm.
3434

3535
##################################
3636
# INITIALISE THE VARIABLES/SCRIPT
@@ -42,8 +42,8 @@ internal_verify_required_containers_are_up;
4242
############################
4343
# CALL THE SHARED FUNCTIONS.
4444
############################
45-
repository_clone;
46-
required_dirs_create ;
45+
repository:clone;
46+
internal_required_dirs_create ;
4747
db:get;
4848
db:load;
4949
composer_config;

project/mage_titans

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ github_args='--depth 1';
3737
resources_storage='local'; # Where to access shared resources (see README.md), 'local' or 's3'
3838
db_host='mysql80'; # 'percona56' or 'percona57'
3939
php_host='php81'; # 'php56', 'php70', 'php72', 'php73' or 'php74'
40-
required_containers=( "nginx" "rediscache" "redissession" "redisfullpage" "elasticsearch716" "gitea" "kibana" "${php_host}" "${db_host}");
40+
required_containers=( "nginx" "rediscache" "redissession" "redisfullpage" "elasticsearch716" "gitea" "kibana" "lighthouse-server" "${php_host}" "${db_host}");
4141
composer_version="2";
4242
db_name='mage_titans'; # unique name for this database
4343
vmhost_name='titans.loc'; # domain name for this project in local vm.
@@ -119,8 +119,8 @@ internal_verify_required_containers_are_up;
119119
# CALL THE SHARED FUNCTIONS.
120120
############################
121121
internal_setup_gitea;
122-
repository_clone;
123-
required_dirs_create ;
122+
repository:clone;
123+
internal_required_dirs_create ;
124124
db:get;
125125
db:load;
126126
composer_config;

project/phpmyadmin

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ custom_setup () {
5252
############################
5353
# CALL THE SHARED FUNCTIONS.
5454
############################
55-
repository_clone;
55+
repository:clone;
5656
composer_install;
5757
custom_setup;
5858
host_entry_display;

project/resources/eg-m2-opensource.loc/configurator/Configuration/global.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
global:
22
-
33
path: web/unsecure/base_url
4-
value: https://eg-m2-opensource.local/
4+
value: https://eg-m2-opensource.loc/
55
-
66
path: web/secure/base_url
7-
value: https://eg-m2-opensource.local/
7+
value: https://eg-m2-opensource.loc/
88
-
99
path: dev/static/sign
1010
value: 0

project/resources/eg-m2-opensource.loc/env.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
'translate' => 1
120120
],
121121
'downloadable_domains' => [
122-
'eg-m2-opensource.local'
122+
'eg-m2-opensource.loc'
123123
],
124124
'install' => [
125125
'date' => 'Wed, 06 Apr 2022 18:15:39 +0000'

0 commit comments

Comments
 (0)