Skip to content

Commit bfb0882

Browse files
zhengruifengHyukjinKwon
authored andcommitted
[SPARK-32407][SPARK-35375][INFRA][DOCS] Delete comments on Sphinx and Jinja2
### What changes were proposed in this pull request? Delete comments on `Sphinx` and `Jinja2` ### Why are the changes needed? they had been upgraded in apache#44012 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#44046 from zhengruifeng/infra_Sphinx_nit. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
1 parent 984e797 commit bfb0882

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

.github/workflows/build_and_test.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -692,10 +692,6 @@ jobs:
692692
- name: Install Python linter dependencies
693693
if: inputs.branch != 'branch-3.3' && inputs.branch != 'branch-3.4' && inputs.branch != 'branch-3.5'
694694
run: |
695-
# TODO(SPARK-32407): Sphinx 3.1+ does not correctly index nested classes.
696-
# See also https://github.com/sphinx-doc/sphinx/issues/7551.
697-
# Jinja2 3.0.0+ causes error when building with Sphinx.
698-
# See also https://issues.apache.org/jira/browse/SPARK-35375.
699695
python3.9 -m pip install 'flake8==3.9.0' pydata_sphinx_theme 'mypy==0.982' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' numpydoc 'jinja2<3.0.0' 'black==23.9.1'
700696
python3.9 -m pip install 'pandas-stubs==1.2.0.53' ipython 'grpcio==1.59.3' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0'
701697
- name: Python linter
@@ -745,10 +741,6 @@ jobs:
745741
Rscript -e "devtools::install_version('preferably', version='0.4', repos='https://cloud.r-project.org')"
746742
- name: Install dependencies for documentation generation
747743
run: |
748-
# TODO(SPARK-32407): Sphinx 3.1+ does not correctly index nested classes.
749-
# See also https://github.com/sphinx-doc/sphinx/issues/7551.
750-
# Jinja2 3.0.0+ causes error when building with Sphinx.
751-
# See also https://issues.apache.org/jira/browse/SPARK-35375.
752744
# Pin the MarkupSafe to 2.0.1 to resolve the CI error.
753745
# See also https://issues.apache.org/jira/browse/SPARK-38279.
754746
python3.9 -m pip install 'sphinx==4.2.0' mkdocs 'pydata_sphinx_theme>=0.13' sphinx-copybutton nbsphinx numpydoc jinja2 'markupsafe==2.0.1' 'pyzmq<24.0.0'

0 commit comments

Comments
 (0)