Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[microNPU] Add support for requantize #9910

Merged
merged 4 commits into from
Jan 24, 2022
Merged

[microNPU] Add support for requantize #9910

merged 4 commits into from
Jan 24, 2022

Conversation

lhutton1
Copy link
Contributor

Adds support for stand-alone requantize operation which is legalized to an identity operation on the NPU.

cc @manupa-arm @mbaret @ekalda @NicolaLancellotti @dchauhan-arm @jacobbohlin

jacobbohlin
jacobbohlin approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@jacobbohlin jacobbohlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

manupak
manupak requested changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good!.
One question and a request to add a further test.

tests/python/contrib/test_ethosu/test_codegen.py Show resolved Hide resolved
tests/python/contrib/test_ethosu/test_legalize.py Show resolved Hide resolved
@lhutton1 lhutton1 mentioned this pull request Jan 18, 2022
Closed
11 tasks
ekalda
ekalda reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but otherwise looks good! :)

tests/python/contrib/test_ethosu/test_codegen.py Show resolved Hide resolved
tests/python/contrib/test_ethosu/test_codegen.py Outdated Show resolved Hide resolved
tests/python/contrib/test_ethosu/test_legalize.py Outdated Show resolved Hide resolved
@lhutton1 lhutton1 force-pushed the requantize branch 2 times, most recently from 057e998 to 4a151cd Compare January 21, 2022 09:31
manupak
manupak approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ekalda
ekalda approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@lhutton1
[microNPU] Add support for requantize
87e5904 
Adds support for stand-alone requantize operation which is legalized to
an identity operation on the NPU.

Change-Id: Ie2450c5fc72f405eddf517593236074aa4716c3b
@lhutton1
fix concatenate tests failing due to not being bit exact
cdf1dd5 
Since requantize is now offloaded, concatenate tests were failing
due a reference not being used.

Change-Id: I44b26b5daecfefb776ca19e6646f3690f5570f52
@lhutton1
test multiple requantize offload
bcb7005 
Change-Id: I60a3283461a7a7083c05289e84f570698388077b
@lhutton1
address comments
c2d90bf 
Change-Id: I7196a0fa468eb7c6a96f2b8a68f3a2dcf5a5693c
@lhutton1
Copy link
Contributor Author

lhutton1 commented Jan 21, 2022 •
edited
Loading

Failure in test_autotune seems unrelated...

>           assert tuner.best_flops > 0
E           assert 0 > 0
E            +  where 0 = <tvm.autotvm.tuner.ga_tuner.GATuner object at 0x7fea7f3f2400>.best_flops

Retriggering.

@github-actions github-actions bot requested a review from manupak January 21, 2022 16:46
@masahi masahi merged commit 74a2fa8 into apache:main Jan 24, 2022
@lhutton1 lhutton1 deleted the requantize branch January 24, 2022 09:06
yuanfz98 pushed a commit to yuanfz98/tvm that referenced this pull request Jan 24, 2022
@lhutton1 @yuanfz98
[microNPU] Add support for requantize (apache#9910)
36c3d56 
* [microNPU] Add support for requantize

Adds support for stand-alone requantize operation which is legalized to
an identity operation on the NPU.

Change-Id: Ie2450c5fc72f405eddf517593236074aa4716c3b

* fix concatenate tests failing due to not being bit exact

Since requantize is now offloaded, concatenate tests were failing
due a reference not being used.

Change-Id: I44b26b5daecfefb776ca19e6646f3690f5570f52

* test multiple requantize offload

Change-Id: I60a3283461a7a7083c05289e84f570698388077b

* address comments

Change-Id: I7196a0fa468eb7c6a96f2b8a68f3a2dcf5a5693c
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
@lhutton1 @ylc
[microNPU] Add support for requantize (apache#9910)
2a068d3 
* [microNPU] Add support for requantize

Adds support for stand-alone requantize operation which is legalized to
an identity operation on the NPU.

Change-Id: Ie2450c5fc72f405eddf517593236074aa4716c3b

* fix concatenate tests failing due to not being bit exact

Since requantize is now offloaded, concatenate tests were failing
due a reference not being used.

Change-Id: I44b26b5daecfefb776ca19e6646f3690f5570f52

* test multiple requantize offload

Change-Id: I60a3283461a7a7083c05289e84f570698388077b

* address comments

Change-Id: I7196a0fa468eb7c6a96f2b8a68f3a2dcf5a5693c
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbohlin jacobbohlin jacobbohlin approved these changes

@ekalda ekalda ekalda approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@icemelon icemelon Awaiting requested review from icemelon

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@jwfromm jwfromm Awaiting requested review from jwfromm

@MarisaKirisame MarisaKirisame Awaiting requested review from MarisaKirisame

@mbrookhart mbrookhart Awaiting requested review from mbrookhart

@merrymercy merrymercy Awaiting requested review from merrymercy

@slyubomirsky slyubomirsky Awaiting requested review from slyubomirsky

@tqchen tqchen Awaiting requested review from tqchen

@vinx13 vinx13 Awaiting requested review from vinx13

@wweic wweic Awaiting requested review from wweic

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

@mbaret mbaret Awaiting requested review from mbaret

@manupak manupak Awaiting requested review from manupak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lhutton1 @jacobbohlin @ekalda @manupak @masahi