-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Runtime][Pipeline Executor] Add the map logic of global input and subgraph input. #9751
Conversation
Thanks for the update @huajsj , I have left additional change requests, otherwise good to me. |
Thanks @liangfu, all review comments addressed, please take a look. |
all review comments addressed, thanks @liangfu. |
…bgraph input. User can use "global input name" to feed input data for pipeline runtime. The name like "data_a" will be mapped into a input interface of subgraph. In this PR, we create the related logic to do the following things. 1. building the input map configuration 2. in runtime c++ module, parseing the input connection configuration then creating related data structure to record the said connection map. 3. providing the function to return the map information for verification.
Thanks for contributing and the updates @huajsj. This is now merged. |
…bgraph input. (apache#9751) * [Runtime][Pipeline Executor] Add the map logic of global input and subgraph input. User can use "global input name" to feed input data for pipeline runtime. The name like "data_a" will be mapped into a input interface of subgraph. In this PR, we create the related logic to do the following things. 1. building the input map configuration 2. in runtime c++ module, parseing the input connection configuration then creating related data structure to record the said connection map. 3. providing the function to return the map information for verification. * address review comments. * addres review comments. * address review comments.
…bgraph input. (apache#9751) * [Runtime][Pipeline Executor] Add the map logic of global input and subgraph input. User can use "global input name" to feed input data for pipeline runtime. The name like "data_a" will be mapped into a input interface of subgraph. In this PR, we create the related logic to do the following things. 1. building the input map configuration 2. in runtime c++ module, parseing the input connection configuration then creating related data structure to record the said connection map. 3. providing the function to return the map information for verification. * address review comments. * addres review comments. * address review comments.
Hello @huajsj I have questions regarding how to set continuous stream inputs into the pipeline module. In the test_pipeline_executor.py, I noticed there is set_input function to set input data.
As far as I understand, multiple inputs are essential to utilize the advantage of pipeline executor. Thanks :) |
This is a follow-up question from the last question. After re-reading your code I notice you created data as batch data for pipeline computation and feed data into the pipeline module. However, from my understanding, It looks like 5 multiple stream inputs are fed to the pipeline module one by one, and each of them runs in sequential mode as the below figure shown. I think this implementation is different from what you claim in your example (running in pipeline format). I am wondering do I misunderstand anything? |
…bgraph input. (apache#9751) * [Runtime][Pipeline Executor] Add the map logic of global input and subgraph input. User can use "global input name" to feed input data for pipeline runtime. The name like "data_a" will be mapped into a input interface of subgraph. In this PR, we create the related logic to do the following things. 1. building the input map configuration 2. in runtime c++ module, parseing the input connection configuration then creating related data structure to record the said connection map. 3. providing the function to return the map information for verification. * address review comments. * addres review comments. * address review comments.
User can use "global input name" to feed input data for pipeline runtime. The name like
"data_a" will be mapped into a input interface of subgraph. In this PR, we
create the related logic to do the following things.
creating related data structure to record the said connection map.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.