[AlterLayout] Strided slice layout transform fix (disallow NCHW4c -> NCHW etc properly) #9245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
MarisaKirisame,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
vinx13
approved these changes
Oct 11, 2021
masahi
added a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
…NCHW etc properly) (apache#9245) * prohibit propagating through packed to unpacked layout * add test
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…NCHW etc properly) (apache#9245) * prohibit propagating through packed to unpacked layout * add test
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…NCHW etc properly) (apache#9245) * prohibit propagating through packed to unpacked layout * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8759
Looking at
StridedSliceInferCorrectLayout, I believe we do not allow propagating a new layout throughstrided_sliceif the original layout is a packed one such asNCHW4cand the new layout is unpacked one, seetvm/src/relay/op/tensor/transform.cc
Lines 2639 to 2641 in 7deebc6
cc @vinx13 who wrote this code.