Address review comments on Arm(R) Ethos(TM)-U PR 3/6 #9159
Conversation
mbaret
requested review from
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
manupak,
MarisaKirisame,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
cc @mbs-octoml @jroesch PTAL |
| scale = np.single(scale.value.value) | ||
| q_params = vapi.NpuQuantization(scale_f32=scale, zero_point=zero_point.value) | ||
| return q_params | ||
| return vapi.NpuQuantization(scale_f32=float(scale), zero_point=int(zero_point)) |
There was a problem hiding this comment.
The only semantic change, right? Can you explain it in the PR summary, thx.
There was a problem hiding this comment.
This function was doing something it didn't need to (per-channel scales never actually appear here), so I just simplified it to remove that confusion. I'll amend the commit message to include reference to this.
|
|
||
| Parameters | ||
| ---------- | ||
| te_graph | ||
| The TE graph to schedule. | ||
| cached_func : CachedFunc |
There was a problem hiding this comment.
Heads up we're trying to move both the TECompiler and CachedFunc structures to be internal only. I think the idea is all the cross-reference stuff accumulated in CachedFunc would be captured as 'official' attributes on the call or defn. So obviously we'll need to include this in that refactor.
|
Apologies for the delay fixing CI here, having some environment problems locally. Will hopefully be fixed by next week. |
Change-Id: I22961885a503be31f6a72622ae0b5f874cc6f463
Change-Id: I3e2fde786096ea331fcb366080fa779ec4ea4a5d
Change-Id: I1026e3ccee33a3fdec9ebbf6456bae244ad4f1d5
* Address review comments on Arm(R) Ethos(TM)-U PR 3/6 Change-Id: I22961885a503be31f6a72622ae0b5f874cc6f463 * Fix rebasing error Change-Id: I3e2fde786096ea331fcb366080fa779ec4ea4a5d * Fix more rebasing problems Change-Id: I1026e3ccee33a3fdec9ebbf6456bae244ad4f1d5
* Address review comments on Arm(R) Ethos(TM)-U PR 3/6 Change-Id: I22961885a503be31f6a72622ae0b5f874cc6f463 * Fix rebasing error Change-Id: I3e2fde786096ea331fcb366080fa779ec4ea4a5d * Fix more rebasing problems Change-Id: I1026e3ccee33a3fdec9ebbf6456bae244ad4f1d5
* Address review comments on Arm(R) Ethos(TM)-U PR 3/6 Change-Id: I22961885a503be31f6a72622ae0b5f874cc6f463 * Fix rebasing error Change-Id: I3e2fde786096ea331fcb366080fa779ec4ea4a5d * Fix more rebasing problems Change-Id: I1026e3ccee33a3fdec9ebbf6456bae244ad4f1d5
This patch addresses the review comments left on #8806. Small changes are made to the API of ScheduleBuilder so that it can be reused in the NPU compiler, allowing us to remove a largely duplicated piece of code.