[MetaSchedule][M3a] TuneContext #9053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxybazh
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu,
zhiics and
a team
as code owners
zxybazh
force-pushed
the
tensorir-infra/upstream/2021-09-20/tune-context
branch
from
6099add
to
e99bb33
Compare
|
Hey you probably need to rebase after #9044 is merged? |
Already rebaed : ) |
junrushao
reviewed
Sep 20, 2021
junrushao
reviewed
Sep 20, 2021
junrushao
reviewed
Sep 20, 2021
junrushao
reviewed
Sep 20, 2021
|
Otherwise looks good to me! Thanks @zxybazh |
Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
zxybazh
force-pushed
the
tensorir-infra/upstream/2021-09-20/tune-context
branch
from
cef26b3
to
9bc31d3
Compare
62 tasks
junrushao
approved these changes
Sep 21, 2021
Hzfengsy
reviewed
Sep 21, 2021
|
Please merge the PR if no further issues, thanks! |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Add TuneContext class. Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> * Add tune context test. * Add meta_schedule to cmake. * Add type. * Rebase. * Disable MyPy for ethosu. * Add new line. * Remove duplicate line. * Minor fix. * Add comments. Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Add TuneContext class. Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> * Add tune context test. * Add meta_schedule to cmake. * Add type. * Rebase. * Disable MyPy for ethosu. * Add new line. * Remove duplicate line. * Minor fix. * Add comments. Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
junrushao
changed the title
manupak
reviewed
Jan 26, 2022
| @@ -29,5 +29,6 @@ mypy --check-untyped-defs python/tvm/tir/analysis/ | |||
| echo "Checking MyPy Type defs in the transform package." | |||
| mypy --check-untyped-defs python/tvm/tir/transform/ | |||
|
|
|||
| echo "Checking MyPy Type defs in the tvm.relay.backend.contrib.ethosu package." | |||
| mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/ | |||
| #TODO(@mikepapadim): This is failing atm | |||
There was a problem hiding this comment.
Please create an issue if things like this happens and possibly ping codeowners please, we were not aware that any of the checked in code was not tested until recently.
There was a problem hiding this comment.
Sure. I thought we did, but it turned out haven't...Please make sure to report in time :-)
There was a problem hiding this comment.
oh actually we reported in this thread: #9050. definitely should submit it as a separate PR though
There was a problem hiding this comment.
Yea but that PR was closed saying not needed. Thus, I was under the impression that was never merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the stage M3a of the meta schedule project (#8473).
The architecture is re-designed by Junru and Xiyou.
TuneContextcontains all the resources, i.e., related classes for a single tuning task. The class can be accessed in both python side and c++ side. No function is designated inside.More classes would be added to
TuneContextas we proceed with the upstreaming.Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>