-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Add support for QLinearConcat contrib op #8907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but LGTM
Awesome to see this thank you @anwang2009 ! Could you add the [ONNX] tag to the PR? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like you hit a flaky test, try relaunching CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
It seems we have a CI error which I'm not sure relates to the PR at all:
|
If you jostle ci via |
* add qlinearconcat op * fix tests * Fix * lint * lint * review * boop ci * fix regression * noop * jostle ci
* add qlinearconcat op * fix tests * Fix * lint * lint * review * boop ci * fix regression * noop * jostle ci
get_scalar
to common point where other Q op impls can reach it._qnn.op.concatenate
will requantize as necessary, so there is nothing special necessary that needs to be done here for this Q op.