-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TensorIR] Support for match_buffer from subregion #8585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
requested review from
areusch,
comaniac,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu,
zhiics and
ZihengJiang
as code owners
July 29, 2021 11:59
tqchen
reviewed
Jul 29, 2021
vinx13
reviewed
Jul 29, 2021
* support match_buffer_region (cherry picked from commit 682ca84cf44d1c0aaf98440effc13e12141cf8e0) * some fix * change match_buffer_region to match_buffer * fix printer and parser * update testcase * Apply suggestions from code review Co-authored-by: Wuwei Lin <wuwei@apache.org>
* add match_buffer support to access ditector (cherry picked from commit b93a593c39a56ebb22c1dce70bfbd4484e581750) * add match_buffer support to lca ditector * tensorcore script * finish e2e tensorcore script * finish e2e tensorcore script
junrushao
approved these changes
Jul 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
29 tasks
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match_buffer
inside a block allow users to mark a subregion of the source buffer into a new target buffer. In the following example it does the same job asA[i, j] = 1
A further step, it is useful for opaque access (e.g. Tensor intrinsic). It can narrow the access region, also provide some additional information, such as strides and shape for buffer after the pass
CompactBuffer
. Please see details at a Tensorcore demo withmatch_buffer
in filetests/python/integration/test_lower.py
Please take a look. thanks a lot. @vinx13 @junrushao1994 @tqchen