[TOPI] Add transpose_a/b & dynamic shape support for batch matmul #8527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcf94
requested review from
anijain2305,
areusch,
comaniac,
Huyuwei,
jroesch,
junrushao,
jwfromm,
kevinthesun,
Laurawly,
MarisaKirisame,
masahi,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
jcf94
changed the title
jcf94
changed the title
|
Also cc @wyc-ruiker , I remember you mentioned the requirement of this in #8402? Seems you need to add topi schedules yourself after merging this. 😆 |
jcf94
force-pushed
the
transpose_batch_matmul
branch
from
f79d12b
to
76e2b46
Compare
jcf94
force-pushed
the
transpose_batch_matmul
branch
from
492ee2f
to
8dac20a
Compare
jcf94
force-pushed
the
transpose_batch_matmul
branch
from
295777b
to
0649ec8
Compare
|
@comaniac Thanks! I think I've addressed all of the comments. I have tested that the default topi schedule works well for all 4 input formats, at least won't cause any error. |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…ache#8527) * Add basic support for batch matmul transpose * Update * Lint fix & add tf convert support * Update Lint fix * Bug fix for qnn.batch_matmul * Bug fix for tensorflow test * Add grad support for batch_matmul * Lint fix Re-triggle CI Bug fix Re-triggle CI Re-triggle CI Re-triggle CI
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ache#8527) * Add basic support for batch matmul transpose * Update * Lint fix & add tf convert support * Update Lint fix * Bug fix for qnn.batch_matmul * Bug fix for tensorflow test * Add grad support for batch_matmul * Lint fix Re-triggle CI Bug fix Re-triggle CI Re-triggle CI Re-triggle CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8234, a new op
nn.matmulwas added to extendnn.densewith transpose/non-transpose inputs support.This PR is going to also extend
nn.batch_matmulto support inputs to be in transpose or non-transposed format.Since the original topi schedule is still for NT format, I set the default format of
nn.batch_matmulto be NT. And for theqnn.batch_matmuland some pass likeCombineParallelBatchMatmul, I just left them to only support NT currently. Guys who are interested in these may continue to fix :)Things TODO in this PR:
cc @comaniac @altanh @tkonolige