-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELAY]Switch from CompileEngine to TECompiler in Interpreter #8486
Conversation
// Backend compile engine. | ||
CompileEngine engine_; | ||
// TE-to-TIR lowerer (compiler). | ||
TECompiler compiler_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not related this pr, but is it possible to hold a customzied TECompiler? Say if it is NPU TECompiler, which has differnent pass flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately we want to enable customized rewrites/transforms at all stages. This work is just getting us out of the go-straight-to-packed-func world so we can have a representation which makes the current te visible.
This is my first week so I'm just wrapping my head around this -- I defer to Jarad for the True Story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xqdan the goal of TECompile is to have one lowering which applies initial scheduling to functions and puts them in the IRModule. After this users can customize the flow for specific targets or executors.
3d7596d
to
fd9e188
Compare
This continues on: https://discuss.tvm.apache.org/t/rfc-relay-tecompiler-rewrite-existing-compile-engine-to-match-updated-compiler-flow/9233 and apache#751, this time just replacing CompileEngine with TECompiler in the Interpreter, using the JIT helper added to help the transition. Some whitespace improvements while there.
fd9e188
to
d233a1c
Compare
@jroesch for review |
// Backend compile engine. | ||
CompileEngine engine_; | ||
// TE-to-TIR lowerer (compiler). | ||
TECompiler compiler_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xqdan the goal of TECompile is to have one lowering which applies initial scheduling to functions and puts them in the IRModule. After this users can customize the flow for specific targets or executors.
CC @icemelon9 for review :-) |
Thanks @mbs-octoml @xqdan @jroesch! It is merged |
This continues on: https://discuss.tvm.apache.org/t/rfc-relay-tecompiler-rewrite-existing-compile-engine-to-match-updated-compiler-flow/9233 and apache#751, this time just replacing CompileEngine with TECompiler in the Interpreter, using the JIT helper added to help the transition. Some whitespace improvements while there.
This continues on: https://discuss.tvm.apache.org/t/rfc-relay-tecompiler-rewrite-existing-compile-engine-to-match-updated-compiler-flow/9233 and apache#751, this time just replacing CompileEngine with TECompiler in the Interpreter, using the JIT helper added to help the transition. Some whitespace improvements while there.
This continues on:
[RFC][Relay] TECompiler: Rewrite existing compile engine to match updated compiler flow
and #7518, this time just replacing CompileEngine with TECompiler in the Interpreter,
using the JIT helper added to help the transition.
Some whitespace improvements while there.