[TEST] Make sure there is no tie in scores in TF combined NMS test #8335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
approved these changes
Jun 24, 2021
trevor-m
approved these changes
Jun 24, 2021
This was referenced Jun 29, 2021
Closed
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove flaky-ness discussed in #8140.
The flaky output from the workload
(1, 64, 20, 4), which uses a different code path than others, seems more frequent. For now I haven't disable it to see if the uniqueness of scores would also fix it. I've run this test 1000 times with this fix and I haven't got an error.@trevor-m @mbrookhart