Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI][batch_matmul] Allow cblas batch_matmul implicit batch_size broadcast #8250

Merged
merged 2 commits into from
Jun 12, 2021

Conversation

ymwangg
Copy link
Contributor

@ymwangg ymwangg commented Jun 11, 2021

This PR enables implicit batch_size broadcast in topi.x86.batch_matmul. This is useful for some NLP models.

python/tvm/topi/x86/batch_matmul.py Show resolved Hide resolved
tests/python/contrib/test_cblas.py Outdated Show resolved Hide resolved
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahi masahi merged commit ab16685 into apache:main Jun 12, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
…adcast (apache#8250)

* Allow cblas batch_matmul implicit bcast

* Add cblas batch_matmul bcast when batch_a=1
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
…adcast (apache#8250)

* Allow cblas batch_matmul implicit bcast

* Add cblas batch_matmul bcast when batch_a=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants