support adb-shell style cpp_rpc #8223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Android Application test log: adb shell test log: |
|
please fix the format problem using clang-format-10 |
FrozenGene
reviewed
Jun 10, 2021
.gitignore
Outdated
Comment on lines
199
to
200
| cmake-build-debug | ||
| cmake-build* |
There was a problem hiding this comment.
your pr should not be related with this .gitignore
There was a problem hiding this comment.
Should I modify .gitignore in another PR ?
There was a problem hiding this comment.
Yes, if you think it is a must
FrozenGene
reviewed
Jun 10, 2021
apps/cpp_rpc/rpc_env.cc
Outdated
| std::string android_base_ = "/data/data/" + std::string(cwd) +"/cache"; | ||
| struct stat statbuf; | ||
| if (stat(android_base_.data(), &statbuf) == -1 || !S_ISDIR(statbuf.st_mode)){ | ||
| android_base_ = "."; |
There was a problem hiding this comment.
If failed, android_base_ becomes ., will ./rpc work well on android?
There was a problem hiding this comment.
When current working directory is writable, Yes .
Another option is force base_ to /data/local/tmp/rpc. But I don't think this is a good choice. So I keep the original implementation .
There was a problem hiding this comment.
how about add one simple code comment to indicate users if failed, should make sure the directory is writable and also consider to change base_ to /data/local/tmp/rpc. This could help users find one solution more quickly
|
@FrozenGene All problems solved |
FrozenGene
reviewed
Jun 15, 2021
apps/cpp_rpc/rpc_env.cc
Outdated
| base_ = "/data/data/" + std::string(cwd) + "/cache/rpc"; | ||
| std::string android_base_ = "/data/data/" + std::string(cwd) + "/cache"; | ||
| struct stat statbuf; | ||
| // Check if application data directory exist. If not exist usually mean tvm_rpc run from adb |
There was a problem hiding this comment.
Nitty comment. If not exist, usually means we run tvm_rpc from adb shell terminal
apps/cpp_rpc/rpc_env.cc
Outdated
| // Check if application data directory exist. If not exist usually mean tvm_rpc run from adb | ||
| // shell terminal. | ||
| if (stat(android_base_.data(), &statbuf) == -1 || !S_ISDIR(statbuf.st_mode)) { | ||
| // Tmp directory always writable for 'shell' user. |
added 2 commits
June 18, 2021 17:12
|
@FrozenGene Thanks for correcting my spelling mistake [Lol] |
FrozenGene
approved these changes
Jun 21, 2021
|
Thanks @fantasyRqg |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* support adb-shell style cpp_rpc * fix review problems, apache#8223 * add comment & use /data/local/tmp dir in shell terminal case * fix spelling errors * fix spelling errors Co-authored-by: rqg <ranqingguo90@qq.com> Co-authored-by: rqg <ranqingguo318@gmail.com>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* support adb-shell style cpp_rpc * fix review problems, apache#8223 * add comment & use /data/local/tmp dir in shell terminal case * fix spelling errors * fix spelling errors Co-authored-by: rqg <ranqingguo90@qq.com> Co-authored-by: rqg <ranqingguo318@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem mentioned at #7390
Support
tvm_rpcdirectly use inadb shellterminal@vinx13 @tqchen