[Relay][PatternLang] Fuzzy Function Matching #7355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wildcard, allow grouping via dominator analysis
masahi
approved these changes
Jan 28, 2021
|
thanks @mbrookhart @comaniac |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
… wildcard, allow grouping via dominator analysis (apache#7355)
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
… wildcard, allow grouping via dominator analysis (apache#7355)
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
… wildcard, allow grouping via dominator analysis (apache#7355)
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
… wildcard, allow grouping via dominator analysis (apache#7355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@comaniac @masahi
I recently ran into a situation where I needed to match based on a function signature, but not necessarily on the function body. To support that, I made some changes to the pattern matcher to allow matching and rewriting functions as long as everything in the match is completely dominated by the pattern.
This works for rewriting, but I haven't been able to get the partitioner to work properly on these tests, so I added a unit test but skipped it with a TODO.
What do you guys think?