Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC][ACL] removed ACL 20.05 limitations #7251

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

d-smirnov
Copy link
Contributor

This PR removes checks for padding in according with changes in ACL 20.11 which currently does not require padded data.

@d-smirnov
Copy link
Contributor Author

@mbaret

Removed checks for padding in according with changes in ACL 20.11

*ACL stands for "Compute Library for the Arm® Architecture"
Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but a question on what's happened with the tests. It seems like you've removed the check for the number of ACL partitions - is this because previously some tests wouldn't offload due to the padding restriction but now they always do?

@d-smirnov
Copy link
Contributor Author

Correct. Tests were restored to initial state (before padding limitations). Now each test always resulted to ACL-partitioned IR so there is no need to have this variations.

@d-smirnov
Copy link
Contributor Author

Ping. How we can make a progress here?

Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@mbaret mbaret merged commit 969b77a into apache:main Jan 20, 2021
@mbaret
Copy link
Contributor

mbaret commented Jan 20, 2021

Thanks @d-smirnov

TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
Removed checks for padding in according with changes in ACL 20.11

*ACL stands for "Compute Library for the Arm® Architecture"
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
Removed checks for padding in according with changes in ACL 20.11

*ACL stands for "Compute Library for the Arm® Architecture"
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
Removed checks for padding in according with changes in ACL 20.11

*ACL stands for "Compute Library for the Arm® Architecture"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants