-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC][ACL] removed ACL 20.05 limitations #7251
Conversation
8779457
to
6e9b18d
Compare
Removed checks for padding in according with changes in ACL 20.11 *ACL stands for "Compute Library for the Arm® Architecture"
6e9b18d
to
c8fe781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK, but a question on what's happened with the tests. It seems like you've removed the check for the number of ACL partitions - is this because previously some tests wouldn't offload due to the padding restriction but now they always do?
Correct. Tests were restored to initial state (before padding limitations). Now each test always resulted to ACL-partitioned IR so there is no need to have this variations. |
Ping. How we can make a progress here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
Thanks @d-smirnov |
Removed checks for padding in according with changes in ACL 20.11 *ACL stands for "Compute Library for the Arm® Architecture"
Removed checks for padding in according with changes in ACL 20.11 *ACL stands for "Compute Library for the Arm® Architecture"
Removed checks for padding in according with changes in ACL 20.11 *ACL stands for "Compute Library for the Arm® Architecture"
This PR removes checks for padding in according with changes in ACL 20.11 which currently does not require padded data.