Scatter on Cuda #6533
Merged
Scatter on Cuda #6533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
reviewed
Sep 22, 2020
mbrookhart
force-pushed
the
mbrookhart/scatter_cuda_schedule
branch
from
2e3c4d4
to
963147a
Compare
Laurawly
reviewed
Oct 2, 2020
|
|
||
| with ib.new_scope(): | ||
| bx = te.thread_axis("blockIdx.x") | ||
| ib.scope_attr(bx, "thread_extent", 1) |
There was a problem hiding this comment.
if bx is not used in this context, we can remove the above two lines.
There was a problem hiding this comment.
If I don't define at least one block in the scope, the generated cuda code fails to compile.
zhiics
reviewed
Oct 2, 2020
mbrookhart
force-pushed
the
mbrookhart/scatter_cuda_schedule
branch
from
963147a
to
488ad3d
Compare
zhiics
reviewed
Oct 8, 2020
|
@zhiics Can we merge this? I want to send a PR to enable |
|
yeah, let's merge this. before that, we probably want to rebase again just in case bad things would happen |
added 4 commits
October 27, 2020 18:02
fix lint fix pylint again
mbrookhart
force-pushed
the
mbrookhart/scatter_cuda_schedule
branch
from
7881b2e
to
03de673
Compare
|
I rebased, I'll keep an eye on it this evening to make sure it still passes CI. Thanks! |
|
Thanks @mbrookhart @Laurawly @tkonolige @masahi |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
* working cuda scatter fix lint fix pylint again * cuda scatter with threading * add dynamic shape tests * remove unused variable
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* working cuda scatter fix lint fix pylint again * cuda scatter with threading * add dynamic shape tests * remove unused variable
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* working cuda scatter fix lint fix pylint again * cuda scatter with threading * add dynamic shape tests * remove unused variable
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* working cuda scatter fix lint fix pylint again * cuda scatter with threading * add dynamic shape tests * remove unused variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to get scatter working with te schedules on cuda due to the two loops that update values in place, so I resorted to using ir_builder directly.
Attempts to better parallelize the algorithm have created some strange behavior. If I can get a correct and faster implementation to work, I'll submit another PR.
Thanks to @tkonolige for very helpful discussions. @notoraptor, this may be useful for your scatter_add work.
cc @zhiics