Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Move support related code to include/tvm/support #4716

Merged
merged 2 commits into from
Jan 15, 2020
Merged

[REFACTOR] Move support related code to include/tvm/support #4716

merged 2 commits into from
Jan 15, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Jan 15, 2020 •
edited
Loading

  • tvm/logging.h -> tvm/support/logging.h
  • remove tvm/base.h, move with into tvm/support/with.h
  • src/common -> src/support for consistency

The term "support" follows llvm terminology of basic support utilities

@tqchen
[REFACTOR] Move support related code to include/tvm/support
40731a3 
- tvm/logging.h -> tvm/support/logging.h
- remove tvm/base.h, move with into tvm/support/with.h
@tqchen
Copy link
Member Author

tqchen commented Jan 15, 2020

cc @yzhliu @ZihengJiang

@tqchen tqchen merged commit 49d3144 into apache:master Jan 15, 2020
@tqchen tqchen deleted the support branch February 10, 2020 19:25
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@tqchen @alexwong
[REFACTOR] Move support related code to include/tvm/support (apache#4716
069115c 
)

* [REFACTOR] Move support related code to include/tvm/support

- tvm/logging.h -> tvm/support/logging.h
- remove tvm/base.h, move with into tvm/support/with.h

* src/common -> src/support
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@tqchen @alexwong
[REFACTOR] Move support related code to include/tvm/support (apache#4716
fa22c2f 
)

* [REFACTOR] Move support related code to include/tvm/support

- tvm/logging.h -> tvm/support/logging.h
- remove tvm/base.h, move with into tvm/support/with.h

* src/common -> src/support
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@tqchen @zhiics
[REFACTOR] Move support related code to include/tvm/support (apache#4716
236613f 
)

* [REFACTOR] Move support related code to include/tvm/support

- tvm/logging.h -> tvm/support/logging.h
- remove tvm/base.h, move with into tvm/support/with.h

* src/common -> src/support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZihengJiang ZihengJiang ZihengJiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tqchen @ZihengJiang