Fix topi bop overloading #3595
Closed
Fix topi bop overloading #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tqchen This test https://github.com/dmlc/tvm/blob/master/tests/python/unittest/test_pass_bound_checkers.py#L450 is flaky. Sometimes it can raise an exception but sometimes not. This happens for master as well. Do you have any idea about it? |
|
I do have a specific idea, please open a flaky issue if you believe it is due to flaky problem, please also tag the authors of bound checkers |
|
superseded by #3612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes bop overloading happens only when at least one operand is non-zero-rank tensor. Otherwise bop will return expr. This should fix #3240.