Fix issue mutating if expressions #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Feb 15, 2019
|
Please add a regression test as per https://docs.tvm.ai/contribute/code_review.html#ensure-test-coverage |
|
@ZihengJiang @yzhliu we might need to consider cherry-pick this patch after release tag |
|
This is merged because we need to cherry pick it for the 0.5 release. @jroesch please send a test case in a followup PR |
tqchen
added
status: accepted
and removed
status: need update
ZihengJiang
pushed a commit
that referenced
this pull request
Feb 18, 2019
(cherry picked from commit f6be4d6)
ZihengJiang
pushed a commit
that referenced
this pull request
Feb 18, 2019
(cherry picked from commit f6be4d6)
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small bug in the Python impl of the expression mutator.