[DOCS] Update document to include security model of RPC server #17377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR update the documents to include the security model of the RPC server.
raboof
reviewed
Sep 16, 2024
docs/reference/security.rst
Outdated
Comment on lines
43
to
44
| TVM RPC server assumes that the user is trusted and needs to be used in a trusted network environment | ||
| and encrypted channels. It allows writings of arbitrary files into the server for benchmarking purposes. |
There was a problem hiding this comment.
This seems like a good addition. Perhaps to make it really clear to users we should also mention that writing arbitrary files typically also leads to full remote code execution capabilities to anyone who can access this API?
There was a problem hiding this comment.
great suggestion, just updated to include explicit discussion about RCE
MasterJH5574
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the documents to include the security model of the RPC server.