Skip to content

Add output_data_sec section in corstone300.ld #15649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2023
Merged

Add output_data_sec section in corstone300.ld #15649

merged 1 commit into from
Sep 4, 2023

Conversation

toyowata
Copy link
Contributor

Fixed output_data_sec section was missing in the corstone300.ld for Ethos-U.

See more detail: #15643

@lhutton1
Copy link
Contributor

lhutton1 commented Sep 1, 2023

Thanks for creating the PR @toyowata. cc @ekalda @ashutosh-arm could you take a look? Perhaps we can do it in a follow-up PR, but I think the task_demo_microtvm.sh script could check the correct prediction was made to prevent regression in the future

@asparkhi
Copy link
Contributor

asparkhi commented Sep 1, 2023

I don't have much idea of the new flag. It will be good to get it reviewed offline from someone who knows more about linker scripts.

lhutton1
lhutton1 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toyowata LGTM!

lhutton1 added a commit to lhutton1/tvm that referenced this pull request Sep 4, 2023
@lhutton1
[microTVM] Check the output of microNPU demos in CI
d5bcaac 
This is a followup from apache#15649 which caught a misclassification
issue when running the microNPU demo. While apache#15649 fixes the issue
and results in the correct classification, this commit ensures the
demo does not regress again in the future.

Change-Id: I816bb7dbba92cf447ff66f26ff881e1586740b6a
@lhutton1 lhutton1 mentioned this pull request Sep 4, 2023
Merged
@lhutton1 lhutton1 merged commit 476d9d1 into apache:main Sep 4, 2023
@lhutton1
Copy link
Contributor

lhutton1 commented Sep 4, 2023

Thanks @toyowata @ashutosh-arm!

@lhutton1 lhutton1 mentioned this pull request Sep 4, 2023
Closed
@toyowata toyowata deleted the ethos_section_fix branch September 4, 2023 22:09
lhutton1 added a commit that referenced this pull request Sep 6, 2023
@lhutton1
[microTVM] Check the output of microNPU demos in CI (#15667)
5d3f3dd 
This is a followup from #15649 which caught a misclassification
issue when running the microNPU demo. While #15649 fixes the issue
and results in the correct classification, this commit ensures the
demo does not regress again in the future.
@ysh329 ysh329 mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhutton1 lhutton1 lhutton1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@toyowata @lhutton1 @asparkhi