Skip to content

Conversation

@Aarsh2001
Copy link
Contributor

Mish - tests pass locally for llvm target on a cpu

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 26, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Aarsh2001
Copy link
Contributor Author

Aarsh2001 commented Jul 26, 2023

cc @mbrookhart @liangfu @masahi @tqchen

@Hzfengsy
Copy link
Member

Please add a testcase for it

@Aarsh2001
Copy link
Contributor Author

Hey @Hzfengsy, I thought tests for the onnx frontend are directly picked from their test suite. There is one for test_mish as well, which executes through the parametrised function, test_onnx_nodes, should i write a separate one ?

@Hzfengsy
Copy link
Member

Please add a standalone test in the file https://github.com/apache/tvm/blob/main/tests/python/frontend/onnx/test_forward.py

@Aarsh2001
Copy link
Contributor Author

Hey @Hzfengsy, just added a test

@Aarsh2001
Copy link
Contributor Author

Hey @Hzfengsy, can this be merged now ?

@Hzfengsy Hzfengsy merged commit 0556653 into apache:main Jul 30, 2023
@Hzfengsy
Copy link
Member

Thanks @Aarsh2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants