Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRT] Remove depreceated intergration tests with mxnet zoo importers #10772

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

mikepapadim
Copy link
Contributor

Currently, under test_tensorrt.py there is a mixture of integration and unit tests.
Integration tests (e.g., from mxnet zoo ) are deprecated and failing since #8901.

This PR removed integrations tests from the pytest runner.

If required, a follow-up PR can introduce integration tests from onnx, however, can increase CI overhead.

@mbaret @mbs-octoml @masahi

@mikepapadim mikepapadim changed the title [TRT] Remove depreceated mointergration tests with mxnet zoo importers [TRT] Remove depreceated intergration tests with mxnet zoo importers Mar 24, 2022
Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using PyTorch if you want to do e2e tests. Many models are available from torchvision, including quantized ones. PT is installed in the gpu image so it is readily available.

@masahi masahi merged commit 9de36f7 into apache:main Mar 25, 2022
@mikepapadim
Copy link
Contributor Author

I recommend using PyTorch if you want to do e2e tests. Many models are available from torchvision, including quantized ones. PT is installed in the gpu image so it is readily available.

+1 for adding these. However, I think it will add a significant t on CI cicles.

pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
…che#10772)

Co-authored-by: Michalis Papapdimitriou <mpapapdimitriou@octoml.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants