Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorIR] Renormalize split pattern #10401

Merged
merged 7 commits into from
Feb 28, 2022
Merged

[TensorIR] Renormalize split pattern #10401

merged 7 commits into from
Feb 28, 2022

Conversation

spectrometerHBH
Copy link
Contributor

This PR adds a transformation pass for arithmetic simplification.

The rational is to transform floordiv(floormod()) pattern to floormod(floordiv()) pattern to allow simplification of inner constants.

cc @junrushao1994 @tqchen

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@junrushao junrushao changed the title [MetaSchedule] Renormalize split pattern [TensorIR] Renormalize split pattern Feb 28, 2022
Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have some naive questions... Would you mind giving a little explanation?

src/tir/transforms/renormalize_split_pattern.cc Outdated Show resolved Hide resolved
@spectrometerHBH spectrometerHBH merged commit 9ca2139 into apache:main Feb 28, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants