-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetaSchedule] Fix Cyclic Dependency in PyClass Family #10368
Merged
junrushao
merged 27 commits into
apache:main
from
zxybazh:bugfix/2022-02-18/fix-cyclic-dependency-on-pyclass
Mar 4, 2022
Merged
[MetaSchedule] Fix Cyclic Dependency in PyClass Family #10368
junrushao
merged 27 commits into
apache:main
from
zxybazh:bugfix/2022-02-18/fix-cyclic-dependency-on-pyclass
Mar 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxybazh
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy,
icemelon and
zhiics
as code owners
February 24, 2022 07:55
zxybazh
force-pushed
the
bugfix/2022-02-18/fix-cyclic-dependency-on-pyclass
branch
from
February 24, 2022 08:22
70a8c34
to
a3567b8
Compare
CC @YuchenJin @sunggg would love to have you guys review this PR :-) Thanks a lot! |
YuchenJin
reviewed
Mar 2, 2022
zxybazh
changed the title
[WIP][MetaSchedule] Fix Cyclic Dependency in PyClass Family
[MetaSchedule] Fix Cyclic Dependency in PyClass Family
Mar 2, 2022
Fix import.
zxybazh
force-pushed
the
bugfix/2022-02-18/fix-cyclic-dependency-on-pyclass
branch
from
March 2, 2022 02:12
ddf9186
to
7c664b6
Compare
junrushao
reviewed
Mar 2, 2022
junrushao
reviewed
Mar 2, 2022
junrushao
reviewed
Mar 2, 2022
junrushao
reviewed
Mar 2, 2022
junrushao
reviewed
Mar 2, 2022
junrushao
approved these changes
Mar 4, 2022
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
Following the design of module_pass, we developed a mechanism, a decorator named derived_obj, to systematically allow derivation from TVM objects in pure Python and being passed into any language, without cyclic dependency. This PR introduces the new mechanism to all PyClasses in meta schedule.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Following the design of module_pass, we developed a mechanism, a decorator named derived_obj, to systematically allow derivation from TVM objects in pure Python and being passed into any language, without cyclic dependency. This PR introduces the new mechanism to all PyClasses in meta schedule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the design of
module_pass
, we developed a mechanism, a decorator namedderived_obj
, to systematically allow derivation from TVM objects in pure Python and being passed into any language, without cyclic dependency. This PR introduces the new mechanism to all PyClasses in meta schedule.Class Migration Progress: