fix RPC waiting for device #10255
Merged
fix RPC waiting for device #10255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfk-beta
requested review from
comaniac,
jcf94,
junrushao,
merrymercy and
vinx13
as code owners
Contributor
Author
pfk-beta
added a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Co-authored-by: pfk-beta <this_email_isnot_working@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR solves issue 10240. Previous implementation for checking device was little misleading/problematic. It was checking device in almost infinite loop (
while not dev.exist), but the thread which was doing this was set with timeout. Check status was equivalent to thread state, imho it's incorrect and misleading.So I have changed to more proper way, but with little duplicated code:
while not dev.exist)