Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][Tracking Issue] Pipeline Executor For Compute graph pipeline #8596

Closed
15 tasks done
huajsj opened this issue Jul 29, 2021 · 14 comments
Closed
15 tasks done

[RFC][Tracking Issue] Pipeline Executor For Compute graph pipeline #8596

huajsj opened this issue Jul 29, 2021 · 14 comments
Labels
type:rfc-tracking RFC progress tracking. Ref: https://github.com/apache/tvm-rfcs

Comments

@huajsj
Copy link
Contributor

huajsj commented Jul 29, 2021

PR #7892
Discussion https://discuss.tvm.apache.org/t/rfc-compute-graph-pipeline-with-new-subgraph-executor/9839/

Steps

Following are the PR list for the feature plan

[Pipeline Executor] Infrastructure

[Enable CPU Affinity]

PR is not in this solution scope but related, separate issue used to track.

Compute graph splitting function PR Tracking Issue
Splitting compute graph into a list of subgraph in C++.
Compute graph automatic splitting PR Tracking Issue
compute graph automatic splitting infrastructure
compute graph auto splitting interface and example
compute graph auto tune and graph splitting algorithm implementation
non-DNN model function pipeline integration support PR Tracking Issue
Add darknet operator for yolov3 data preparation(pre-processing )
Add darknet operator for yolov3 detection result analysis(post processing)
@comaniac
Copy link
Contributor

@huajsj please update this issue with a PR checklist. Please link all future PRs to this issue for better progress tracking.
You can refer to other RFC issues like #8473

@comaniac comaniac added the type:rfc-tracking RFC progress tracking. Ref: https://github.com/apache/tvm-rfcs label Sep 15, 2021
@huajsj
Copy link
Contributor Author

huajsj commented Nov 11, 2021

@comaniac , thanks for the follow up, just saw this comments, already done.

@comaniac
Copy link
Contributor

@comaniac , thanks for the follow up, just saw this comments, already done.

Could you update the issue with a complete plan (e.g., milestones, expected PRs) instead of adding one line when filing a PR? Otherwise people won't have an idea about how many PRs you are going to send and what milestone you have achieved.

@huajsj
Copy link
Contributor Author

huajsj commented Nov 11, 2021

@comaniac , sure, already add the future PR plan.

@huajsj
Copy link
Contributor Author

huajsj commented Nov 29, 2021

@comaniac, I just updated this issue to move these planned PR not belong to this solution to sperate tables to avoid confuse, please check.

@rebel-shshin
Copy link
Contributor

@huajsj Thanks for the nice job.

@masahi
Copy link
Member

masahi commented Feb 15, 2022

At one point can we expect a non-trivial demo?

@huajsj
Copy link
Contributor Author

huajsj commented Feb 16, 2022

thanks @masahi for the follow up, I am also looking forward a chance to do a demo after all patch upstream done.

@rebel-shshin
Copy link
Contributor

rebel-shshin commented Mar 15, 2022

thanks @masahi for the follow up, I am also looking forward a chance to do a demo after all patch upstream done.

Hi @huajsj, do you have any plan to do a demo with compiling deep learning models such as [TF model to relay](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py](https://github.com/apache/tvm/issues/url) ?

And I think it would be helpful to the TVM users if you provide an example with BYOC also. Thank you very much :)

@huajsj
Copy link
Contributor Author

huajsj commented Apr 6, 2022

thanks @masahi for the follow up, I am also looking forward a chance to do a demo after all patch upstream done.

Hi @huajsj, do you have any plan to do a demo with compiling deep learning models such as [TF model to relay](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py%5D(https://github.com/apache/tvm/issues/url)) ?

And I think it would be helpful to the TVM users if you provide an example with BYOC also. Thank you very much :)

@rebel-shshin, thanks for the follow up, yes, a tutorial is a very good suggestion, actually we are working on the related document, I would add a tutorial task under this issue for tracking purpose.

@rebel-shshin
Copy link
Contributor

thanks @masahi for the follow up, I am also looking forward a chance to do a demo after all patch upstream done.

Hi @huajsj, do you have any plan to do a demo with compiling deep learning models such as [TF model to relay](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py%5D(https://github.com/apache/tvm/issues/url)) ?
And I think it would be helpful to the TVM users if you provide an example with BYOC also. Thank you very much :)

@rebel-shshin, thanks for the follow up, yes, a tutorial is a very good suggestion, actually we are working on the related document, I would add a tutorial task under this issue for tracking purpose.

Thank you very much :)

@huajsj
Copy link
Contributor Author

huajsj commented Jul 23, 2022

thanks @masahi for the follow up, I am also looking forward a chance to do a demo after all patch upstream done.

Hi @huajsj, do you have any plan to do a demo with compiling deep learning models such as [TF model to relay](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py%5D(https://github.com/apache/tvm/issues/url)) ?
And I think it would be helpful to the TVM users if you provide an example with BYOC also. Thank you very much :)

@rebel-shshin, thanks for the follow up, yes, a tutorial is a very good suggestion, actually we are working on the related document, I would add a tutorial task under this issue for tracking purpose.

Thank you very much :)

Hi @rebel-shshin , tutorial already there, #11557.

@huajsj
Copy link
Contributor Author

huajsj commented Jul 23, 2022

all the task done, thanks @comaniac and @masahi for the kindly review, thanks @rebel-shshin for the follow up, close this issue now.

@huajsj huajsj closed this as completed Jul 23, 2022
@rebel-shshin
Copy link
Contributor

thanks @masahi for the follow up, I am also looking forward a chance to do a demo after all patch upstream done.

Hi @huajsj, do you have any plan to do a demo with compiling deep learning models such as [TF model to relay](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py](https://tvm.apache.org/docs/how_to/compile_models/from_tensorflow.html#sphx-glr-how-to-compile-models-from-tensorflow-py%5D(https://github.com/apache/tvm/issues/url)) ?
And I think it would be helpful to the TVM users if you provide an example with BYOC also. Thank you very much :)

@rebel-shshin, thanks for the follow up, yes, a tutorial is a very good suggestion, actually we are working on the related document, I would add a tutorial task under this issue for tracking purpose.

Thank you very much :)

Hi @rebel-shshin , tutorial already there, #11557.

Thank you very much : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:rfc-tracking RFC progress tracking. Ref: https://github.com/apache/tvm-rfcs
Projects
None yet
Development

No branches or pull requests

4 participants