Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] v0.12.0 release schedule #14505

Closed
7 tasks done
ysh329 opened this issue Apr 5, 2023 · 34 comments
Closed
7 tasks done

[Release] v0.12.0 release schedule #14505

ysh329 opened this issue Apr 5, 2023 · 34 comments
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug

Comments

@ysh329
Copy link
Contributor

ysh329 commented Apr 5, 2023

Although v0.11.0 released on Feb 25 and a relative bugfix minor version v0.11.1 released last month, relative PRs are all the last year November. This is unhealthy for our RFC-0067 about quarter-based releases, especially for AI infra companies which needs regularly merge with release version.

Consider v0.11.0 features are from last year Nov and quarter-based releases, I hope at the end of this month we can make a release version.

In order to continue with our agreed release cycle as per discussion in RFC#67 , I'd like to propose a schedule for our next TVM release: v0.12.0.

This schedule is tentative and may change as we progress through the process. In case dates change, this thread will be kept updated.

The proposed schedule is:

Call for release managers: in case you want to be involved in upcoming releases, please manifest your interest in this thread and we'll try to organise.

See also:

cc @apache/tvm-committers @driazati @areusch @Mousius @tqchen @AndrewZhaoLuo

@ysh329 ysh329 added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug labels Apr 5, 2023
@Hzfengsy
Copy link
Member

Hzfengsy commented Apr 6, 2023

Thanks @ysh329 Happy to see volunteers for the quarterly. Please fix the following issue of the post

a tag v0.12.dev0 to be created, marking the beginning of the next development cycle

typo, should be v0.13.dev0

Note: for this specific release, given we'll have the end of the year period, I've extended the cherry-picking hard deadline in ~3 days, so that we some more time to consider patches to be included.

remove it

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 6, 2023

Thanks @ysh329 Happy to see volunteers for the quarterly. Please fix the following issue of the post

a tag v0.12.dev0 to be created, marking the beginning of the next development cycle

typo, should be v0.13.dev0

Note: for this specific release, given we'll have the end of the year period, I've extended the cherry-picking hard deadline in ~3 days, so that we some more time to consider patches to be included.

remove it

Fixed. Thanks your reply.

@Johnson9009
Copy link
Contributor

@ysh329 Thanks for bring this up, upgrade with official timely is good for the downstream companies, especially for companies like ARM China whose customers want to use the newest release version timely.

Thanks for excellent work of TVM community, ARM China built our heterogeneous execution product based on TVM, and learned a lot from community, so this quarter we will pay some time to help release the v0.12.0, @ysh329 is our team member, we will try our best to complete this release in Apr, so the downstream have more time to upgrade and resolve conflicts.

@tqchen @junrushao @AndrewZhaoLuo Please help to check if we release v0.12.0 at this time is ok? Thanks.

@areusch
Copy link
Contributor

areusch commented Apr 7, 2023

the timeline looks good to me, we do need someone to serve as release manager.

@tqchen
Copy link
Member

tqchen commented Apr 7, 2023

Happy to help with some of the branch cutting works, Thanks @ysh329 for volunteering, would you be able to help release note drafting?

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 8, 2023

Happy to help with some of the branch cutting works, Thanks @ysh329 for volunteering, would you be able to help release note drafting?

My pleasure. I'm recently preparing release note drafting. 😆

Please help create branch named v0.12.0 from main and v0.13.dev0 tag. @tqchen @Hzfengsy @junrushao

@Hzfengsy Hzfengsy pinned this issue Apr 9, 2023
@Hzfengsy
Copy link
Member

Hzfengsy commented Apr 9, 2023

I helped create the v0.12.0 branch and will set the tag after the next commit merges. Could you please also send a PR to update the dev version like the commit #14241

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 9, 2023

I helped create the v0.12.0 branch and will set the tag after the next commit merges. Could you please also send a PR to update the dev version like the commit #14241

Fixed. Please see #14544.

@xingyu-long
Copy link

Hi @ysh329, I am quite interested in being the release manager for this project. Do you have any requirements for it? And how can I get in touch with you or the team? Thanks!

@Hzfengsy
Copy link
Member

@ysh329 tag v0.13dev0 created

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 10, 2023

Hi @ysh329, I am quite interested in being the release manager for this project. Do you have any requirements for it? And how can I get in touch with you or the team? Thanks!

Thanks for your attention. We are already in the process of this release. Please feel free to raise your questions about release in this issue.

@tqchen
Copy link
Member

tqchen commented Apr 10, 2023

#14571 needs to be cherry picked cc @Lunderberg

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 16, 2023

Hi @driazati I'm recently prepraing the release note, but I met a problem after create csv files. My step is following readme, it mentions below:

You can then import this CSV into a collaborative spreadsheet editor to distribute the work of categorizing PRs for the notes. Once done, you can download the resulting CSV and convert it to readable release notes.

However, after csv files generated and make each row own its category by handed, but I'm confused about:

I met error when executing python3 ./make_notes.py --notes-csv out-large.csv:

{'oid': '8e9216013ced6b9655359a696a5bb1bf68fdd638', 'committedDate': '2023-04-08T12:48:48Z', 'associatedPullRequests': {'nodes': [{'number': 14533, 'additions': 2, 'changedFiles': 1, 'de
letions': 1, 'author': {'login': 'shtinsa'}, 'title': '[hexagon] Hexagon inference fix', 'body': '1. Resolves issue with kernels linking.\r\n2. Fixes warning generated by clang-15.'}]}}
Opening CSV                                                                                                                                                                               
Traceback (most recent call last):
  File "/home/ysh329/code/tvm/tests/scripts/release/make_notes.py", line 92, in <module>
    category = row["category"].strip()
KeyError: 'category'

What does the excepted categoried csv file look like before executing make_notes.py? It seems csv file generated by gather_prs.py which is not compatible with make_note.py.

Can u give me some suggestions?

@driazati
Copy link
Member

driazati commented Apr 17, 2023

Hi @driazati I'm recently prepraing the release note, but I met a problem after create csv files. My step is following readme, it mentions below:

You can then import this CSV into a collaborative spreadsheet editor to distribute the work of categorizing PRs for the notes. Once done, you can download the resulting CSV and convert it to readable release notes.

However, after csv files generated and make each row own its category by handed, but I'm confused about:

I met error when executing python3 ./make_notes.py --notes-csv out-large.csv:

{'oid': '8e9216013ced6b9655359a696a5bb1bf68fdd638', 'committedDate': '2023-04-08T12:48:48Z', 'associatedPullRequests': {'nodes': [{'number': 14533, 'additions': 2, 'changedFiles': 1, 'de
letions': 1, 'author': {'login': 'shtinsa'}, 'title': '[hexagon] Hexagon inference fix', 'body': '1. Resolves issue with kernels linking.\r\n2. Fixes warning generated by clang-15.'}]}}
Opening CSV                                                                                                                                                                               
Traceback (most recent call last):
  File "/home/ysh329/code/tvm/tests/scripts/release/make_notes.py", line 92, in <module>
    category = row["category"].strip()
KeyError: 'category'

What does the excepted categoried csv file look like before executing make_notes.py? It seems csv file generated by gather_prs.py which is not compatible with make_note.py.

Can u give me some suggestions?

Hey, those scripts are mostly just a guideline, we haven't really devoted support to making it a polished pipeline for generating release notes. For those to work there is a manual step of categorizing each PR listed from gather_prs.py into a CSV with the headers referenced in make_notes.py, so that's why they don't hook straight up to each other. I've attached a sample of the list of categorized PRs used in v0.9.0 for reference: Release Notes v0.9.0 - PRs with _ 150 lines changed.csv.

Either way the scripts aren't strictly necessary, you can always make the release notes manually if that ends up easier.

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 17, 2023

Hi @driazati I'm recently prepraing the release note, but I met a problem after create csv files. My step is following readme, it mentions below:

You can then import this CSV into a collaborative spreadsheet editor to distribute the work of categorizing PRs for the notes. Once done, you can download the resulting CSV and convert it to readable release notes.

However, after csv files generated and make each row own its category by handed, but I'm confused about:
I met error when executing python3 ./make_notes.py --notes-csv out-large.csv:

{'oid': '8e9216013ced6b9655359a696a5bb1bf68fdd638', 'committedDate': '2023-04-08T12:48:48Z', 'associatedPullRequests': {'nodes': [{'number': 14533, 'additions': 2, 'changedFiles': 1, 'de
letions': 1, 'author': {'login': 'shtinsa'}, 'title': '[hexagon] Hexagon inference fix', 'body': '1. Resolves issue with kernels linking.\r\n2. Fixes warning generated by clang-15.'}]}}
Opening CSV                                                                                                                                                                               
Traceback (most recent call last):
  File "/home/ysh329/code/tvm/tests/scripts/release/make_notes.py", line 92, in <module>
    category = row["category"].strip()
KeyError: 'category'

What does the excepted categoried csv file look like before executing make_notes.py? It seems csv file generated by gather_prs.py which is not compatible with make_note.py.
Can u give me some suggestions?

Hey, those scripts are mostly just a guideline, we haven't really devoted support to making it a polished pipeline for generating release notes. For those to work there is a manual step of categorizing each PR listed from gather_prs.py into a CSV with the headers referenced in make_notes.py, so that's why they don't hook straight up to each other. I've attached a sample of the list of categorized PRs used in v0.9.0 for reference: Release Notes v0.9.0 - PRs with _ 150 lines changed.csv.

Either way the scripts aren't strictly necessary, you can always make the release notes manually if that ends up easier.

Thanks your reply. Lean a lot from your PRs.

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 18, 2023

#14571 needs to be cherry picked cc @Lunderberg

Please check whether this PR has been cherry picked to branch v0.12.0. @Lunderberg @tqchen @junrushao

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 22, 2023

#14571 needs to be cherry picked cc @Lunderberg

Please check whether this PR has been cherry picked to branch v0.12.0. @Lunderberg @tqchen @junrushao

Cherry-picked #14709
cc @junrushao

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 23, 2023

After cherry-picked PRs merged to branch v0.12.0, we need :

  1. Create a tag named v0.12.0.rc0 on latest commit on branch v0.12.0, and create a release page based on this tag. Need help;
  2. Upload a zip file to ASF SVN on this address (same as [VOTE] Release Apache TVM v0.11.0.rc0 #14129): https://dist.apache.org/repos/dist/dev/tvm/tvm-v0.12.0-rc0/. However, this progress needs ASF account. Need help;
  3. Create a VOTE named: [VOTE] Release Apache TVM v0.12.0.rc0. [VOTE] Release Apache TVM v0.12.0.rc0 #14710

cc @junrushao @Hzfengsy @tqchen

@Johnson9009
Copy link
Contributor

@ysh329 After cherry-picked PRs, the version of TVM need to be updated to "v0.12.0", like what we discussed at #14260, thanks.

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 24, 2023

@ysh329 After cherry-picked PRs, the version of TVM need to be updated to "v0.12.0", like what we discussed at #14260, thanks.

The version was updated, see below.

I helped create the v0.12.0 branch and will set the tag after the next commit merges. Could you please also send a PR to update the dev version like the commit #14241

Fixed. Please see #14544.

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 24, 2023

@ysh329 After cherry-picked PRs, the version of TVM need to be updated to "v0.12.0", like what we discussed at #14260, thanks.

The version was updated, see below.

I helped create the v0.12.0 branch and will set the tag after the next commit merges. Could you please also send a PR to update the dev version like the commit #14241

Fixed. Please see #14544.

Sorry, I misunderstood. The version number on branch v0.12.0 fixed. #14712

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 25, 2023

Hi all, the version number modification on branch v0.12.0 #14712 currently is blocked by CI #14715. I worry may delay expected date (25 Apr 2023) of release voting opens.

Because after this PR #14712 merged, we need:

  1. Create tag v0.12.0.rc0 on latest commit on branch v0.12.0 and create release page based on this tag;
  2. Upload the Release Candidate to ASF SVN.

Above two points finished, then we start release voting opens #14710.

@driazati
Copy link
Member

Can we cherry pick #14538 as well?

more context: #14715 (comment)

@ysh329
Copy link
Contributor Author

ysh329 commented Apr 29, 2023

Hi all, the PR of version number modification on branch v0.12.0 #14712 #14739 was merged. Next we need do two things below, please help. @Hzfengsy @junrushao @tqchen

  1. Create tag v0.12.0.rc0 on latest commit on branch v0.12.0 and create release page based on this tag;
  2. Upload the Release Candidate to ASF SVN.

Above two points finished, then we start release voting opens #14710.

Therefore, I think the final release day may delay to mid May.

@ysh329
Copy link
Contributor Author

ysh329 commented May 6, 2023

Hi all, vote starts (#14710). Everyone is welcomed to vote. Please vote by replying to this thread explicitly. Vote will close May. 12th at 23:59M GMT.
cc @leandron @vinx13 @Hzfengsy @junrushao @driazati @AndrewZhaoLuo @masahi @tqchen

@ysh329
Copy link
Contributor Author

ysh329 commented May 13, 2023

Hi all, vote passes #14844 , next we'll upload the binaries to Apache mirrors and create a new release TAG named v0.12.0 meanwhile remove the pre-release candidate TAG v0.12.0.rc0. This program needs help please.

cc @Hzfengsy @junrushao

Besides, I have a problem about Update the TVM Website:

  1. It seems there's a long time no PRs on this project apache/tvm-site. I didn't find relative PR about v0.11.0 doc update(s). Is this doc about [Update the TVM Website] long time no maintenance, now obsolete?
  2. I followed this step, but it need a link inspecting the CI logs for the most recent build of the release branch such as https://tvm-jenkins-artifacts-prod.s3.us-west-2.amazonaws.com/tvm/v0.9.0/1/docs/docs.tgz. However, I dont' know the valid link for v0.12.0?
  3. Besides, does this step need ASF or other authority either?

cc @leandron @areusch @AndrewZhaoLuo @vinx13 @tqchen

@vinx13
Copy link
Member

vinx13 commented May 13, 2023

@ysh329 Thanks for spotting this. The download page is broken now, it only includes links for v0.8 release. This is because previous PRs to tvm-site wasn't send to main branch, so manual rebuild of the site will overwrite the contents.
The update of the site should follow steps: 1) send PR to tvm-site/main to update download links and run scripts/task_deploy_asf_site.sh 2) push docs to asf-site branch

@ysh329
Copy link
Contributor Author

ysh329 commented May 13, 2023

@ysh329 Thanks for spotting this. The download page is broken now, it only includes links for v0.8 release. This is because previous PRs to tvm-site wasn't send to main branch, so manual rebuild of the site will overwrite the contents. The update of the site should follow steps: 1) send PR to tvm-site/main to update download links and run scripts/task_deploy_asf_site.sh 2) push docs to asf-site branch

Thanks your reply. I'm confused. According to the update-the-tvm-website, it seems download page is necessary, but now it's broken. Then the PR which you said in first step couldn't be ready?

Besides, does this step need ASF or other authority either?

@tqchen
Copy link
Member

tqchen commented May 13, 2023

Let us update the download page, this step would need ASF perm, @vinx13 @Hzfengsy can you help?

@vinx13
Copy link
Member

vinx13 commented May 14, 2023

I have pushed to svn server and sent PR to update download page apache/tvm-site#41

@ysh329
Copy link
Contributor Author

ysh329 commented May 15, 2023

I have pushed to svn server and sent PR to update download page apache/tvm-site#41

Great!

Does this new steps about update the docs on website exist big difference than before? Do we need update the docs about this part?

@vinx13
Copy link
Member

vinx13 commented May 15, 2023

There is no big difference except some missing details in the doc. The link to the artifact can be found in the CI log, but I found the link is broken because the last build for v0.12.0 branch is two weeks ago and the artifact was removed, so I rerun the CI and download the artifact.

@ysh329
Copy link
Contributor Author

ysh329 commented May 17, 2023

Hi all, we only left last step to final destination 🥇 below:

Upload the binaries to Apache mirrors and create a new release TAG named v0.12.0 meanwhile remove the pre-release candidate TAG v0.12.0.rc0. This program needs help please.

cc @Hzfengsy @junrushao

@Hzfengsy Hzfengsy unpinned this issue May 17, 2023
@ysh329
Copy link
Contributor Author

ysh329 commented May 17, 2023

Hi all, v0.12.0 released https://github.com/apache/tvm/releases/tag/v0.12.0. Greatly thanks for everyone! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug
Projects
None yet
Development

No branches or pull requests

8 participants