Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Relay] TVM generates input name that cannot be imported with the parser #12362

Closed
mehrdadh opened this issue Aug 10, 2022 · 3 comments
Closed
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug

Comments

@mehrdadh
Copy link
Member

mehrdadh commented Aug 10, 2022

I'm compiling an ONNX model which I realized the input name has this format input:0. When I import the model and run it, it works fine, however if I try to import the same Relay text with the parser it will result in error.

cc @gigiblender

@slyubomirsky
Copy link
Contributor

Can you write a simple pass that will change ("sanitize") the variable names? I don't know if a colon is treated in any special way by the parser, but you could try replacing them with underscores. I thought the parser did some sanitization of its own and am surprised that this still happens.

@mehrdadh
Copy link
Member Author

mehrdadh commented Oct 7, 2022

@slyubomirsky I added a cleanup step in the ONNX frontend to replace : with _.

@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@driazati
Copy link
Member

This seems like it's fixed by #13046, if that's not the case we can re-open this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug
Projects
None yet
Development

No branches or pull requests

4 participants