[FFI][REFACTOR] Cleanup namespace

This PR cleansup the namespace to ensure all ffi classes
are accessed through ffi:: namespace.
It will helps to cleanup the ffi package before isolation.

Author: tqchen

apps/hexagon_launcher/launcher_core.cc

@@ -163,7 +163,7 @@ tvm::runtime::Module load_module(const std::string& file_name) {
   return tvm::runtime::Module();
 }
 
-std::ostream& operator<<(std::ostream& os, const tvm::Array<tvm::String>& strings) {
+std::ostream& operator<<(std::ostream& os, const tvm::ffi::Array<tvm::ffi::String>& strings) {
   os << '[';
   for (int i = 0, e = strings.size(); i != e; ++i) {
     if (i != 0) os << ',';
@@ -191,7 +191,7 @@ tvm::runtime::Module create_graph_executor(const std::string& graph_json,
 
 tvm::runtime::Module create_aot_executor(tvm::runtime::Module factory_module, tvm::Device device) {
   tvm::ffi::Function list_modules = get_module_func(factory_module, "list_module_names");
-  tvm::Array<tvm::String> module_names = list_modules();
+  tvm::ffi::Array<tvm::ffi::String> module_names = list_modules();
   if (module_names.size() != 1) {
     LOG(WARNING) << __func__ << ": expecting single module, got: " << module_names << ", using "
                  << module_names[0];

apps/ios_rpc/tvmrpc/TVMRuntime.mm

@@ -116,7 +116,7 @@ void Init(const std::string& name) {
   namespace refl = tvm::ffi::reflection;
   refl::GlobalDef().def_packed("ffi.Module.load_from_file.dylib_custom",
                                [](ffi::PackedArgs args, ffi::Any* rv) {
-                                 auto n = make_object<UnsignedDSOLoader>();
+                                 auto n = ffi::make_object<UnsignedDSOLoader>();
                                  n->Init(args[0]);
                                  *rv = tvm::ffi::CreateLibraryModule(n);
                                });

docs/arch/pass_infra.rst

@@ -93,9 +93,9 @@ needs to be executed when running under a user-provided optimization level. The
 .. code:: c++
 
     class PassInfoNode : public Object {
-      String name;
+      ffi::String name;
       int opt_level;
-      Array<String> required;
+      ffi::Array<ffi::String> required;
     };
 
 PassContext
@@ -125,11 +125,11 @@ Python APIs to create a compilation pipeline using pass context.
     class PassContextNode : public Object {
      public:
       int opt_level{2};
-      tvm::Array<tvm::Expr> required_pass;
-      tvm::Array<tvm::Expr> disabled_pass;
-      mutable Optional<DiagnosticContext> diag_ctx;
-      Map<String, Any> config;
-      Array<instrument::PassInstrument> instruments;
+      tvm::ffi::Array<tvm::Expr> required_pass;
+      tvm::ffi::Array<tvm::Expr> disabled_pass;
+      mutable ffi::Optional<DiagnosticContext> diag_ctx;
+      ffi::Map<ffi::String, Any> config;
+      ffi::Array<instrument::PassInstrument> instruments;
     };
 
     class PassContext : public NodeRef {
@@ -262,7 +262,7 @@ of passes for execution.
     class SequentialPassNode : PassNode {
       PassInfo pass_info;
       // Passes need to be executed.
-      Array<Pass> passes;
+      ffi::Array<Pass> passes;
       bool PassEnabled(const PassInfo& info) const;
       Module operator()(const Module& mod, const PassContext& pass_ctx) const final;
     };
@@ -321,22 +321,22 @@ favorably use Python APIs to create a specific pass object.
     Pass CreateFunctionPass(
         std::function<Function(Function, IRModule, PassContext)> pass_func,
         int opt_level,
-        String name,
-        Array<String> required);
+        ffi::String name,
+        ffi::Array<ffi::String> required);
 
     Pass CreatePrimFuncPass(
         std::function<PrimFunc(PrimFunc, IRModule, PassContext)> pass_func,
         int opt_level,
-        String name,
-        Array<String> required);
+        ffi::String name,
+        ffi::Array<ffi::String> required);
 
     Pass CreateModulePass(
         std::function<IRModule(IRModule, PassContext)> pass_func,
         int opt_level,
-        String name,
-        Array<String> required);
+        ffi::String name,
+        ffi::Array<ffi::String> required);
 
-    Pass Sequential(tvm::Array<Pass> passes, PassInfo pass_info);
+    Pass Sequential(tvm::ffi::Array<Pass> passes, PassInfo pass_info);
 
 Pass Registration
 ^^^^^^^^^^^^^^^^^
@@ -440,7 +440,7 @@ Multiple ``PassInstrument`` instances can be registed into a single
 
     class PassInstrumentNode : public Object {
      public:
-      String name;
+      ffi::String name;
       virtual void EnterPassContext() const = 0;
       virtual void ExitPassContext() const = 0;
       virtual bool ShouldRun(const IRModule& mod, const transform::PassInfo& info) const = 0;

ffi/include/tvm/ffi/cast.h

@@ -73,8 +73,5 @@ inline ObjectPtr<BaseType> GetObjectPtr(ObjectType* ptr) {
   return details::ObjectUnsafe::ObjectPtrFromUnowned<BaseType>(ptr);
 }
 }  // namespace ffi
-
-using ffi::GetObjectPtr;
-using ffi::GetRef;
 }  // namespace tvm
 #endif  // TVM_FFI_CAST_H_

ffi/include/tvm/ffi/container/array.h

@@ -1140,7 +1140,5 @@ inline constexpr bool type_contains_v<Array<T>, Array<U>> = type_contains_v<T, U
 }  // namespace details
 
 }  // namespace ffi
-
-using ffi::Array;
 }  // namespace tvm
 #endif  // TVM_FFI_CONTAINER_ARRAY_H_

ffi/include/tvm/ffi/container/map.h

@@ -1755,7 +1755,5 @@ inline constexpr bool type_contains_v<Map<K, V>, Map<KU, VU>> =
 }  // namespace details
 
 }  // namespace ffi
-
-using ffi::Map;
 }  // namespace tvm
 #endif  // TVM_FFI_CONTAINER_MAP_H_

ffi/include/tvm/ffi/container/variant.h

@@ -298,7 +298,5 @@ template <typename... V, typename T>
 inline constexpr bool type_contains_v<Variant<V...>, T> = (type_contains_v<V, T> || ...);
 }  // namespace details
 }  // namespace ffi
-
-using ffi::Variant;
 }  // namespace tvm
 #endif  // TVM_FFI_CONTAINER_VARIANT_H_

ffi/include/tvm/ffi/dtype.h

@@ -38,8 +38,6 @@ namespace ffi {
  * \brief Extension code beyond the DLDataType.
  *
  * This class is always consistent with the DLPack.
- *
- * TODO(tvm-team): update to latest DLPack types.
  */
 enum DLExtDataTypeCode { kDLExtCustomBegin = 129 };
 

ffi/include/tvm/ffi/memory.h

@@ -225,7 +225,5 @@ inline ObjectPtr<ArrayType> make_inplace_array_object(size_t num_elems, Args&&..
 }
 
 }  // namespace ffi
-
-using ffi::make_object;
 }  // namespace tvm
 #endif  // TVM_FFI_MEMORY_H_

ffi/include/tvm/ffi/optional.h

@@ -410,7 +410,5 @@ class Optional<T, std::enable_if_t<use_ptr_based_optional_v<T>>> : public Object
   }
 };
 }  // namespace ffi
-
-using ffi::Optional;
 }  // namespace tvm
 #endif  // TVM_FFI_OPTIONAL_H_